[SPARK-39327][K8S] ExecutorRollPolicy.ID should consider ID as a numerical value#36715
Closed
williamhyun wants to merge 1 commit intoapache:masterfrom
williamhyun:SPARK-39327
Closed
[SPARK-39327][K8S] ExecutorRollPolicy.ID should consider ID as a numerical value#36715williamhyun wants to merge 1 commit intoapache:masterfrom williamhyun:SPARK-39327
williamhyun wants to merge 1 commit intoapache:masterfrom
williamhyun:SPARK-39327
Conversation
Member
Author
|
cc: @dongjoon-hyun |
dongjoon-hyun
approved these changes
May 29, 2022
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM (Pending CIs).
Thank you, @williamhyun .
dongjoon-hyun
pushed a commit
that referenced
this pull request
May 29, 2022
…rical value This PR aims to make `ExecutorRollPolicy.ID` should consider ID as a numerical value. Currently, the ExecutorRollPolicy chooses the smallest ID from string sorting. No, 3.3.0 is not released yet. Pass the CIs. Closes #36715 from williamhyun/SPARK-39327. Authored-by: William Hyun <william@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 97f4b0c) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
sunchao
pushed a commit
to sunchao/spark
that referenced
this pull request
Jun 2, 2023
…rical value This PR aims to make `ExecutorRollPolicy.ID` should consider ID as a numerical value. Currently, the ExecutorRollPolicy chooses the smallest ID from string sorting. No, 3.3.0 is not released yet. Pass the CIs. Closes apache#36715 from williamhyun/SPARK-39327. Authored-by: William Hyun <william@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 97f4b0c) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 109904e) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to make
ExecutorRollPolicy.IDshould consider ID as a numerical value.Why are the changes needed?
Currently, the ExecutorRollPolicy chooses the smallest ID from string sorting.
Does this PR introduce any user-facing change?
No, 3.3.0 is not released yet.
How was this patch tested?
Pass the CIs.