Skip to content

Conversation

@adrian-wang
Copy link
Contributor

So the optimizations are not valid. Also I think the optimization here is rarely encounter, so removing them will not have influence on performance.

Can we merge #3445 before I add a comparison test case from this?

@SparkQA
Copy link

SparkQA commented Dec 11, 2014

Test build #24357 has started for PR 3675 at commit 42df763.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 11, 2014

Test build #24357 has finished for PR 3675 at commit 42df763.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24357/
Test PASSed.

@adrian-wang adrian-wang changed the title [SQL] sum and avg on empty table should always return null [SPARK-4828] [SQL] sum and avg on empty table should always return null Dec 11, 2014
@liancheng
Copy link
Contributor

LGTM, thanks!

@marmbrus
Copy link
Contributor

Thanks! Merged to master.

@asfgit asfgit closed this in acb3be6 Dec 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants