[SPARK-39466][CORE][TESTS] Ensure clean core/temp-secrets/ directory after SecurityManagerSuite#36867
Closed
LuciferYang wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-39466][CORE][TESTS] Ensure clean core/temp-secrets/ directory after SecurityManagerSuite#36867LuciferYang wants to merge 1 commit intoapache:masterfrom
core/temp-secrets/ directory after SecurityManagerSuite#36867LuciferYang wants to merge 1 commit intoapache:masterfrom
Conversation
LuciferYang
changed the title
core/temp-secrets/ directory after SecurityManagerSuitecore/temp-secrets/ directory after SecurityManagerSuite
dongjoon-hyun
approved these changes
Jun 14, 2022
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @LuciferYang .
Merged to master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr refactor
createTempSecretFileinSecurityManagerSuiteto ensure cleancore/temp-secrets/directory afterSecurityManagerSuite.Why are the changes needed?
To ensure clean
core/temp-secrets/directory afterSecurityManagerSuite.Does this PR introduce any user-facing change?
No
How was this patch tested?
run following commands:
Before
The
core/temp-secrets/directory is not cleaned upAfter
The
core/temp-secrets/directory has been cleaned up