[SPARK-39649][PYTHON] Make listDatabases / getDatabase / listColumns / refreshTable in PySpark support 3-layer-namespace#37039
Closed
zhengruifeng wants to merge 4 commits intoapache:masterfrom
Closed
Conversation
zhengruifeng
force-pushed
the
py_3l_remaining
branch
from
8347409 to
1ba02fc
Compare
zhengruifeng
changed the title
zhengruifeng
force-pushed
the
py_3l_remaining
branch
2 times, most recently
from
e0fe35d to
5a63be9
Compare
zhengruifeng
changed the title
zhengruifeng
changed the title
Contributor
Author
amaliujia
reviewed
Jul 2, 2022
python/pyspark/sql/catalog.py
Outdated
Contributor
There was a problem hiding this comment.
I was not aware of this though:
Is the catalog=None because of current catalog is not set? I am asking because I thought every DB should have a catalog.
Contributor
Author
There was a problem hiding this comment.
because of the old code path, which intilize a Database with null catalog:
Contributor
There was a problem hiding this comment.
let's fix this at scala side as well later.
amaliujia
reviewed
Jul 2, 2022
Contributor
There was a problem hiding this comment.
No need to add a freshtable API test on Python side?
Contributor
Author
|
also cc @HyukjinKwon if you have some time |
zhengruifeng
force-pushed
the
py_3l_remaining
branch
from
7d3835d to
45cc2d0
Compare
nit fix refresh test fix refresh test rm files use 3L
zhengruifeng
force-pushed
the
py_3l_remaining
branch
from
23dc664 to
55b14a1
Compare
cloud-fan
approved these changes
Jul 4, 2022
Contributor
|
thanks, merging to master! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
make following commands in pyspark support 3-layer-namespace
setCurrentDatabase(per the comments https://github.com/apache/spark/pull/36969/files#diff-e6c98e62b4d35c54acd0481006733a84d6a12dec0a59b3d3024e103d708fae88R70-R71, skipsetCurrentDatabase)Why are the changes needed?
to support 3-layer-namespace
Does this PR introduce any user-facing change?
yes, new api added
How was this patch tested?
updated UT