Skip to content

Comments

[SPARK-39701][CORE][K8S][TESTS] Move withSecretFile to SparkFunSuite to reuse#37106

Closed
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
dongjoon-hyun:SPARK-39701
Closed

[SPARK-39701][CORE][K8S][TESTS] Move withSecretFile to SparkFunSuite to reuse#37106
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
dongjoon-hyun:SPARK-39701

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Jul 6, 2022

What changes were proposed in this pull request?

This PR aims to move withSecretFile to SparkFunSuite and reuse it in Kubernetes tests.

Why are the changes needed?

Currently, K8s unit tests generate a leftover because it doesn't clean up the temporary secret files. By reusing the existing method, we can avoid this

$ build/sbt -Pkubernetes "kubernetes/test"
$ git status
On branch master
Your branch is up to date with 'apache/master'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	resource-managers/kubernetes/core/temp-secret/

Does this PR introduce any user-facing change?

No. This is a test-only change.

How was this patch tested?

Pass the CIs.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-39701][CORE][K8S][TESTS] Move withSecretFile to SparkFunSuite to reuse [SPARK-39701][CORE][K8S][TESTS] Move withSecretFile to SparkFunSuite to reuse Jul 6, 2022
@dongjoon-hyun
Copy link
Member Author

Could you review this, @viirya ?

Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dongjoon-hyun
Copy link
Member Author

dongjoon-hyun commented Jul 6, 2022

Thank you, @viirya . Merged to master.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-39701 branch July 7, 2022 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants