[SPARK-39701][CORE][K8S][TESTS] Move withSecretFile to SparkFunSuite to reuse#37106
Closed
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
dongjoon-hyun:SPARK-39701
Closed
[SPARK-39701][CORE][K8S][TESTS] Move withSecretFile to SparkFunSuite to reuse#37106dongjoon-hyun wants to merge 1 commit intoapache:masterfrom dongjoon-hyun:SPARK-39701
withSecretFile to SparkFunSuite to reuse#37106dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
dongjoon-hyun:SPARK-39701
Conversation
withSecretFile to SparkFunSuite to reuse
Member
Author
|
Could you review this, @viirya ? |
Member
Author
|
Thank you, @viirya . Merged to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to move
withSecretFiletoSparkFunSuiteand reuse it in Kubernetes tests.Why are the changes needed?
Currently, K8s unit tests generate a leftover because it doesn't clean up the temporary secret files. By reusing the existing method, we can avoid this
Does this PR introduce any user-facing change?
No. This is a test-only change.
How was this patch tested?
Pass the CIs.