Closed
Conversation
Member
|
Are they all in the codebase? |
Contributor
Author
Yes, I inspect all scala code in spark by
|
HyukjinKwon
approved these changes
Jul 11, 2022
|
Can one of the admins verify this patch? |
Member
|
Merged to master. |
Contributor
Author
I am very sorry, I miss some scala code with the same problem. @HyukjinKwon |
HyukjinKwon
pushed a commit
that referenced
this pull request
Jul 11, 2022
### What changes were proposed in this pull request? Remove redundant return in scala code. The pr followup: #37148 ### Why are the changes needed? Syntactic simplification. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. Closes #37157 from panbingkun/remove_redundance_return_followup. Authored-by: panbingkun <pbk1982@gmail.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove redundant return in scala code.
Why are the changes needed?
Syntactic simplification.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.