[SPARK-39773][SQL][DOCS] Update document of JDBC options for pushDownOffset#37186
Closed
beliefer wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-39773][SQL][DOCS] Update document of JDBC options for pushDownOffset#37186beliefer wants to merge 2 commits intoapache:masterfrom
pushDownOffset#37186beliefer wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
Author
|
ping @huaxingao cc @cloud-fan |
HyukjinKwon
reviewed
Jul 14, 2022
docs/sql-data-sources-jdbc.md
Outdated
| <td><code>pushDownOffset</code></td> | ||
| <td><code>false</code></td> | ||
| <td> | ||
| The option to enable or disable OFFSET push-down into V2 JDBC data source. The default value is false, in which case Spark will not push down OFFSET to the JDBC data source. Otherwise, if sets to true, SPARK will try to push down OFFSET to the JDBC data source. If <code>pushDownOffset</code> is true and <code>numPartitions</code> is equals to 1, OFFSET will be pushed down to the JDBC data source. Otherwise, OFFSET will not be pushed down and SPARK still applies OFFSET on the result from data source. |
Contributor
There was a problem hiding this comment.
nit: is equals to 1 => equals 1 or is equal to 1
cloud-fan
approved these changes
Jul 15, 2022
Contributor
|
thanks, merging to master! |
Contributor
Author
|
@cloud-fan @HyukjinKwon @huaxingao Thank you ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Because the DS v2 pushdown framework added new JDBC option
pushDownOffsetfor offset pushdown, we should update sql-data-sources-jdbc.md.Why are the changes needed?
Add doc for
pushDownOffset.Does this PR introduce any user-facing change?
'No'. Updated for new feature.
How was this patch tested?
N/A