[SPARK-39818][SQL] Fix bug in ARRAY, STRUCT, MAP types with DEFAULT values with NULL field(s)#37229
Closed
dtenedor wants to merge 2 commits intoapache:masterfrom
dtenedor:fix-bug-sql
Closed
[SPARK-39818][SQL] Fix bug in ARRAY, STRUCT, MAP types with DEFAULT values with NULL field(s)#37229dtenedor wants to merge 2 commits intoapache:masterfrom dtenedor:fix-bug-sql
dtenedor wants to merge 2 commits intoapache:masterfrom
dtenedor:fix-bug-sql
Conversation
Contributor
Author
|
Hi @gengliangwang, sorry I created a bug recently. This PR fixes it for Apache Spark. |
Member
|
Thanks, merging to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix bug in SQL string generation for literal values of ARRAY, STRUCT, MAP types with DEFAULT values with NULL field(s). Specifically, prevent Scala
MatchErrors from getting raised when attempting to call thesqlmethod of theLiteralexpression for such values when one of their fields isnull.Why are the changes needed?
This fixes a bug by preventing exceptions from being inappropriately raised.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
This PR adds new unit test coverage.