[SPARK-40009][PYTHON][DOCS] Add missing doc string info to DataFrame API#37441
Closed
khalidmammadov wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-40009][PYTHON][DOCS] Add missing doc string info to DataFrame API#37441khalidmammadov wants to merge 2 commits intoapache:masterfrom
khalidmammadov wants to merge 2 commits intoapache:masterfrom
Conversation
khalidmammadov
changed the title
Contributor
Author
|
@HyukjinKwon @srowen please review |
srowen
reviewed
Aug 8, 2022
Member
srowen
left a comment
srowen
left a comment
There was a problem hiding this comment.
Seems fine; do you want to add more missing docstrings in one go?
|
Can one of the admins verify this patch? |
Member
|
Yeah can we fix the whole file instead of one API alone? |
HyukjinKwon
reviewed
Aug 9, 2022
|
|
||
| Also as standard in SQL, this function resolves columns by position (not by name). | ||
|
|
||
| Note: This is identical to :func:`union` function |
Member
There was a problem hiding this comment.
Let's just probably mention that it's an alias, and remove Examples section.
Member
|
BTW thanks for working on this @khalidmammadov |
Contributor
Author
|
Sure, will work on whole file and revert |
Contributor
Author
|
@HyukjinKwon @srowen please review |
khalidmammadov
changed the title
Contributor
Author
|
I have also checked how they look using |
srowen
approved these changes
Aug 14, 2022
Member
|
Merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding examples and parameters description to union and unionAll
What changes were proposed in this pull request?
Documentation enhancements
Why are the changes needed?
Help user to understand functions
Does this PR introduce any user-facing change?
Yes, improves documentation
How was this patch tested?
unit test