[MINOR][DOCS] Rename Global to Glob#37484
Closed
khaledh wants to merge 2 commits intoapache:masterfrom
khaledh:patch-1
Closed
[MINOR][DOCS] Rename Global to Glob#37484khaledh wants to merge 2 commits intoapache:masterfrom khaledh:patch-1
khaledh wants to merge 2 commits intoapache:masterfrom
khaledh:patch-1
Conversation
This section is about the path **glob** filter. The word **global** seems to be a mistake.
srowen
approved these changes
Aug 13, 2022
Member
srowen
left a comment
srowen
left a comment
There was a problem hiding this comment.
glob is actually short for global but you are right, it is called glob
Member
|
I'm sure this change doesn't break any tests, but can you enable tests to run in your fork? |
|
Can one of the admins verify this patch? |
Contributor
Author
|
I enabled GitHub Actions in my fork. |
Member
|
Hm, looks like it still didn't run, you're sure? needs a push too |
Contributor
Author
|
Pushed an immaterial change and got a green build. |
Member
|
Merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This section is about the path glob filter. The word global seems to be a mistake.
What changes were proposed in this pull request?
Just a typo fix.
Why are the changes needed?
To be less confusing in what the section is about.
Does this PR introduce any user-facing change?
Apart from docs, no.
How was this patch tested?
No testing needed.