[SPARK-39989][SQL][FollowUp] Improve foldable expression stats estimate for string and binary#37532
Closed
linhongliu-db wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-39989][SQL][FollowUp] Improve foldable expression stats estimate for string and binary#37532linhongliu-db wants to merge 3 commits intoapache:masterfrom
linhongliu-db wants to merge 3 commits intoapache:masterfrom
Conversation
linhongliu-db
force-pushed
the
SPARK-39989
branch
from
0a08e73 to
233062b
Compare
linhongliu-db
changed the title
Contributor
Author
wangyum
reviewed
Sep 3, 2022
...main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/EstimationUtils.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Sep 6, 2022
| object EstimationUtils { | ||
|
|
||
| /** Returns true iff the we support column statistics on column of the given type. */ | ||
| def supportsType(dataType: DataType): Boolean = dataType match { |
Contributor
There was a problem hiding this comment.
is it only for constants?
cloud-fan
reviewed
Sep 7, 2022
| case DoubleType | FloatType => true | ||
| case BooleanType => true | ||
| case DateType => true | ||
| case TimestampType => true |
Contributor
There was a problem hiding this comment.
how about AnsiIntervalType?
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR improves the foldable expression statistics estimation by providing more accurate min, max, and data length for string and binary data types.
Why are the changes needed?
Improve the accuracy of the statistics.
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT