Skip to content

[SPARK-40133][SQL][TESTS] Update excluded TPC-DS queries golden files #37562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SPARK-40133][SQL][TESTS] Update excluded TPC-DS queries golden files #37562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d218dbf
Up to date
wangyum Aug 18, 2022
83c700e
regenerateGoldenFiles
wangyum Aug 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions core/src/test/scala/org/apache/spark/SparkFunSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,8 @@ abstract class SparkFunSuite

protected val enableAutoThreadAudit = true

protected val regenerateGoldenFiles: Boolean = System.getenv("SPARK_GENERATE_GOLDEN_FILES") == "1"

protected override def beforeAll(): Unit = {
System.setProperty(IS_TESTING.key, "true")
if (enableAutoThreadAudit) {
Expand Down
1 change: 0 additions & 1 deletion core/src/test/scala/org/apache/spark/SparkThrowableSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ class SparkThrowableSuite extends SparkFunSuite {
"core/testOnly *SparkThrowableSuite -- -t \"Error classes are correctly formatted\""
}}}
*/
private val regenerateGoldenFiles: Boolean = System.getenv("SPARK_GENERATE_GOLDEN_FILES") == "1"
Copy link
Contributor

@cloud-fan cloud-fan Aug 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry I may miss some context. What problem do we fix by moving this to SparkFunSuite?

Copy link
Member Author

@wangyum wangyum Aug 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TPCDSBase needs this parameter:
image

private val errorClassDir = getWorkspaceFilePath(
"core", "src", "main", "resources", "error").toFile

Expand Down
284 changes: 144 additions & 140 deletions sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q34.sf100/explain.txt
View file
Open in desktop

Large diffs are not rendered by default.

24 changes: 12 additions & 12 deletions ...core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q34.sf100/simplified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,33 +26,33 @@ WholeStageCodegen (10)
Filter [ss_store_sk,ss_hdemo_sk,ss_customer_sk]
ColumnarToRow
InputAdapter
Scan parquet default.store_sales [ss_customer_sk,ss_hdemo_sk,ss_store_sk,ss_ticket_number,ss_sold_date_sk]
Scan parquet spark_catalog.default.store_sales [ss_customer_sk,ss_hdemo_sk,ss_store_sk,ss_ticket_number,ss_sold_date_sk]
SubqueryBroadcast [d_date_sk] #1
ReusedExchange [d_date_sk] #4
BroadcastExchange #4
WholeStageCodegen (1)
Project [d_date_sk]
Filter [d_dom,d_year,d_date_sk]
ColumnarToRow
InputAdapter
Scan parquet spark_catalog.default.date_dim [d_date_sk,d_year,d_dom]
InputAdapter
BroadcastExchange #4
WholeStageCodegen (1)
Project [d_date_sk]
Filter [d_dom,d_year,d_date_sk]
ColumnarToRow
InputAdapter
Scan parquet default.date_dim [d_date_sk,d_year,d_dom]
ReusedExchange [d_date_sk] #4
InputAdapter
BroadcastExchange #5
WholeStageCodegen (2)
Project [s_store_sk]
Filter [s_county,s_store_sk]
ColumnarToRow
InputAdapter
Scan parquet default.store [s_store_sk,s_county]
Scan parquet spark_catalog.default.store [s_store_sk,s_county]
InputAdapter
BroadcastExchange #6
WholeStageCodegen (3)
Project [hd_demo_sk]
Filter [hd_vehicle_count,hd_dep_count,hd_buy_potential,hd_demo_sk]
ColumnarToRow
InputAdapter
Scan parquet default.household_demographics [hd_demo_sk,hd_buy_potential,hd_dep_count,hd_vehicle_count]
Scan parquet spark_catalog.default.household_demographics [hd_demo_sk,hd_buy_potential,hd_dep_count,hd_vehicle_count]
InputAdapter
WholeStageCodegen (8)
Sort [c_customer_sk]
Expand All @@ -62,4 +62,4 @@ WholeStageCodegen (10)
Filter [c_customer_sk]
ColumnarToRow
InputAdapter
Scan parquet default.customer [c_customer_sk,c_salutation,c_first_name,c_last_name,c_preferred_cust_flag]
Scan parquet spark_catalog.default.customer [c_customer_sk,c_salutation,c_first_name,c_last_name,c_preferred_cust_flag]
Loading