[SPARK-39310][PS] Change requires_same_anchor to check_same_anchor#37585
Closed
Yikun wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-39310][PS] Change requires_same_anchor to check_same_anchor#37585Yikun wants to merge 1 commit intoapache:masterfrom
requires_same_anchor to check_same_anchor#37585Yikun wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
cc @itholic |
HyukjinKwon
approved these changes
Aug 20, 2022
Member
|
Merged to master. |
Contributor
|
Sorry, I couldn't been focusing on review for some personal health issue. Thanks for addressing this, @Yikun ! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Change
requires_same_anchortocheck_same_anchorfor_update_internal_framefuncWhy are the changes needed?
There were some discussion in #36353 (comment) , this parameter is a flag for whether checking the same anchor.
Consider it's a parameter of internal use function, it can be renamed safely.
Does this PR introduce any user-facing change?
No
How was this patch tested?
CI passed