[SPARK-40152][SQL][TESTS] Move tests from SplitPart to elementAt#37637
Closed
wangyum wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-40152][SQL][TESTS] Move tests from SplitPart to elementAt#37637wangyum wants to merge 1 commit intoapache:masterfrom
wangyum wants to merge 1 commit intoapache:masterfrom
Conversation
cloud-fan
approved these changes
Aug 24, 2022
HyukjinKwon
approved these changes
Aug 24, 2022
Member
|
Merged to master |
HyukjinKwon
reviewed
Aug 27, 2022
| checkEvaluation(ElementAt(str, Literal(10), outOfBoundValue), UTF8String.fromString("")) | ||
| checkEvaluation(ElementAt(str, Literal(-10), outOfBoundValue), UTF8String.fromString("")) | ||
|
|
||
| checkEvaluation(ElementAt(StringSplitSQL(Literal.create(null, StringType), delimiter), |
Member
There was a problem hiding this comment.
This fails with ANSI mode on:
[info] - elementAt *** FAILED *** (309 milliseconds)
[info] Exception evaluating element_at(stringsplitsql(11.12.13, .), 10, Some(), true) (ExpressionEvalHelper.scala:205)
[info] org.scalatest.exceptions.TestFailedException:
[info] at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:472)
[info] at org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:471)
[info] at org.scalatest.funsuite.AnyFunSuite.newAssertionFailedException(AnyFunSuite.scala:1563)
[info] at org.scalatest.Assertions.fail(Assertions.scala:949)
[info] at org.scalatest.Assertions.fail$(Assertions.scala:945)
[info] at org.scalatest.funsuite.AnyFunSuite.fail(AnyFunSuite.scala:1563)
[info] at org.apache.spark.sql.catalyst.expressions.ExpressionEvalHelper.checkEvaluationWithoutCodegen(ExpressionEvalHelper.scala:205)
[info] at org.apache.spark.sql.catalyst.expressions.ExpressionEvalHelper.checkEvaluationWithoutCodegen$(ExpressionEvalHelper.scala:199)
[info] at org.apache.spark.sql.catalyst.expressions.CollectionExpressionsSuite.checkEvaluationWithoutCodegen(CollectionExpressionsSuite.scala:39)
[info] at org.apache.spark.sql.catalyst.expressions.ExpressionEvalHelper.checkEvaluation(ExpressionEvalHelper.scala:87)
[info] at org.apache.spark.sql.catalyst.expressions.ExpressionEvalHelper.checkEvaluation$(ExpressionEvalHelper.scala:82)
[info] at org.apache.spark.sql.catalyst.expressions.CollectionExpressionsSuite.checkEvaluation(CollectionExpressionsSuite.scala:39)
[info] at org.apache.spark.sql.catalyst.expressions.CollectionExpressionsSuite.$anonfun$new$333(CollectionExpressionsSuite.scala:1546)
https://github.com/apache/spark/runs/8046961366?check_suite_focus=true
HyukjinKwon
pushed a commit
that referenced
this pull request
Aug 27, 2022
Move tests from SplitPart to elementAt in CollectionExpressionsSuite. Simplify test. No. N/A. Closes #37637 from wangyum/SPARK-40152-3. Authored-by: Yuming Wang <yumwang@ebay.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 06997d6) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Member
|
Merged to branch-3.3 too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Move tests from SplitPart to elementAt in CollectionExpressionsSuite.
Why are the changes needed?
Simplify test.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
N/A.