Skip to content

[SPARK-40220][SQL] Don't output the empty map of error message parameters#37660

Closed
MaxGekk wants to merge 1 commit intoapache:masterfrom
MaxGekk:no-empty-messageParameters
Closed

[SPARK-40220][SQL] Don't output the empty map of error message parameters#37660
MaxGekk wants to merge 1 commit intoapache:masterfrom
MaxGekk:no-empty-messageParameters

Conversation

@MaxGekk
Copy link
Member

@MaxGekk MaxGekk commented Aug 25, 2022

What changes were proposed in this pull request?

In the PR, I propose to output the JSON map messageParameters of error messages in the MINIMAL and STANDARD formats only when the map is not empty.

Why are the changes needed?

To be consistent w/ output of other JSON fields of error messages.

Does this PR introduce any user-facing change?

Yes. The PR can change user-facing error message in the MINIMAL and STANDARD formats of error messages.

How was this patch tested?

By running the affected test suites:

$ build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite"

@MaxGekk MaxGekk marked this pull request as ready for review August 25, 2022 16:59
@MaxGekk MaxGekk changed the title [WIP][SPARK-40220][SQL] Don't output the empty map of error message parameters [SPARK-40220][SQL] Don't output the empty map of error message parameters Aug 25, 2022
@MaxGekk
Copy link
Member Author

MaxGekk commented Aug 25, 2022

@srielau @anchovYu Please, have a look at the PR.

@MaxGekk
Copy link
Member Author

MaxGekk commented Aug 26, 2022

Merging to master. Thank you, @srielau @cloud-fan for review.

@MaxGekk MaxGekk closed this in ef78e75 Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants