-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-40313][PS] Make ps.DataFrame(data, index) support the same anchor
#37768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
HyukjinKwon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. Cc @ueshin
itholic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good otherwise!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we test it with the MultiIndex and other index types such as CategoricalIndex and TimedeltaIndex ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let me add them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
2a19763 to
38044d7
Compare
|
Merged to master. |
|
Thank you @itholic @HyukjinKwon for reivews |
What changes were proposed in this pull request?
Make
ps.DataFrame(data, index)support the same anchorWhy are the changes needed?
before:
after:
Does this PR introduce any user-facing change?
yes, DataFrame creation now support same anchor
How was this patch tested?
added UT