[SPARK-40471][BUILD] Upgrade RoaringBitmap to 0.9.32 #37914
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
will check MapStatusesConvertBenchmark result later |
LuciferYang
commented
Sep 16, 2022
| Num Maps: 50000 Fetch partitions:500 1001 1033 36 0.0 1000638934.0 1.0X | ||
| Num Maps: 50000 Fetch partitions:1000 1699 1705 7 0.0 1699358972.0 0.6X | ||
| Num Maps: 50000 Fetch partitions:1500 2647 2855 314 0.0 2646904255.0 0.4X | ||
| Num Maps: 50000 Fetch partitions:500 1179 1187 13 0.0 1178581948.0 1.0X |
Contributor
Author
There was a problem hiding this comment.
Let me double check the base data
Contributor
Author
There was a problem hiding this comment.
run this bench without this pr
================================================================================================
MapStatuses Convert Benchmark
================================================================================================
OpenJDK 64-Bit Server VM 1.8.0_345-b01 on Linux 5.15.0-1019-azure
Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
MapStatuses Convert: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
Num Maps: 50000 Fetch partitions:500 1150 1156 5 0.0 1149981444.0 1.0X
Num Maps: 50000 Fetch partitions:1000 2304 2322 18 0.0 2304318021.0 0.5X
Num Maps: 50000 Fetch partitions:1500 3557 3792 377 0.0 3556704966.0 0.3X
HyukjinKwon
approved these changes
Sep 17, 2022
dongjoon-hyun
approved these changes
Sep 17, 2022
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @LuciferYang and @HyukjinKwon .
Merged to master.
LuciferYang
added a commit
to LuciferYang/spark
that referenced
this pull request
Sep 20, 2022
### What changes were proposed in this pull request? This pr aims upgrade RoaringBitmap 0.9.32 ### Why are the changes needed? This is a bug fix version: - RoaringBitmap/RoaringBitmap#575 - RoaringBitmap/RoaringBitmap#578 other changes as follows: - RoaringBitmap/RoaringBitmap@0.9.31...0.9.32 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions Closes apache#37914 from LuciferYang/SPARK-40471. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr aims upgrade RoaringBitmap 0.9.32
Why are the changes needed?
This is a bug fix version:
other changes as follows:
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GitHub Actions