[SPARK-40486][PS] Implement spearman and kendall in DataFrame.corrwith#37929
Closed
zhengruifeng wants to merge 4 commits intoapache:masterfrom
Closed
[SPARK-40486][PS] Implement spearman and kendall in DataFrame.corrwith#37929zhengruifeng wants to merge 4 commits intoapache:masterfrom
spearman and kendall in DataFrame.corrwith#37929zhengruifeng wants to merge 4 commits intoapache:masterfrom
Conversation
Contributor
Author
7f242bf to
2ea62a8
Compare
HyukjinKwon
approved these changes
Sep 20, 2022
Contributor
Author
|
Merged into master, thanks for review! @HyukjinKwon |
itholic
reviewed
Sep 21, 2022
| method : str, default 'pearson' | ||
| Method of correlation, one of: | ||
|
|
||
| method : {'pearson', 'spearman', 'kendall'} |
Contributor
Contributor
Author
There was a problem hiding this comment.
good question, I think it's a bit hard to support this callable:
it takes two arrays, so should collect all values in the columns, but it's not scalable then
maybe, we can support another callable: Callable[[Column, Column], float], which is an aggregation function, this may make sense. I think we need more discussion/thoughs on it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changes were proposed in this pull request?
DataFrame.corrintocorrelation.py, so it should be able to reused inDataFrame.corrwith/DataFrameGroupBy.corrwith/DataFrameGroupBy.corr/etc;spearmanandkendallinDataFrame.corrwithaxisinDataFrame.corrwith;Why are the changes needed?
For API coverage
Does this PR introduce any user-facing change?
yes, new correlations supported
How was this patch tested?
added UT