[SPARK-40096][CORE][TESTS][FOLLOW-UP] Explicitly check the element and length#37989
Closed
HyukjinKwon wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-40096][CORE][TESTS][FOLLOW-UP] Explicitly check the element and length#37989HyukjinKwon wants to merge 1 commit intoapache:masterfrom
HyukjinKwon wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
cc @mridulm FYI |
srowen
approved these changes
Sep 25, 2022
HyukjinKwon
force-pushed
the
SPARK-40096-followup
branch
from
bd5ad9f to
87698bb
Compare
Member
|
Merged to master |
Contributor
|
This is very interesting behavior ! |
HyukjinKwon
commented
Sep 27, 2022
| .finalizeShuffleMerge(any(), any(), any(), any(), any()) | ||
| assert(sentHosts === Seq("hostB")) | ||
| assert(sentHosts.nonEmpty) | ||
| assert(sentHosts.head === "hostB" && sentHosts.length == 1) |
Member
Author
There was a problem hiding this comment.
Ah, okay. Seems like this is flaky because of the timeout:
[info] - SPARK-40096: Send finalize events even if shuffle merger blocks indefinitely with registerMergeResults is false *** FAILED *** (106 milliseconds)
[info] ArrayBuffer("hostB") was empty (DAGSchedulerSuite.scala:4498)
[info] org.scalatest.exceptions.TestFailedException:
[info] at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:472)
[info] at org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:471)
[info] at org.scalatest.Assertions$.newAssertionFailedException(Assertions.scala:1231)
[info] at org.scalatest.Assertions$AssertionsHelper.macroAssert(Assertions.scala:1295)
[info] at org.apache.spark.scheduler.DAGSchedulerSuite.$anonfun$new$286(DAGSchedulerSuite.scala:4498)
[info] at org.scalatest.OutcomeOf.outcomeOf(OutcomeOf.scala:85)
[info] at org.scalatest.OutcomeOf.outcomeOf$(OutcomeOf.scala:83)
[info] at org.scalatest.OutcomeOf$.outcomeOf(OutcomeOf.scala:104)
[info] at org.scalatest.Transformer.apply(Transformer.scala:22)
[info] at org.scalatest.Transformer.apply(Transformer.scala:20)
https://github.com/apache/spark/actions/runs/3129263557/jobs/5078150518
I think it was empty when the condition is checked. Later, I think the array is filled at the time when the exception is actually printed out.
Contributor
There was a problem hiding this comment.
I think this might a consequence of using MyDAGScheduler - scheduleShuffleMergeFinalize is overridden and runs within the calling thread, instead of async - which this test is expecting.
+CC @otterc, @venkata91
Member
Author
There was a problem hiding this comment.
Hmmm .. this is actually more flaky than I thought:
- https://github.com/apache/spark/actions/runs/3145115911/jobs/5112006948
- https://github.com/apache/spark/actions/runs/3146198025/jobs/5114387367
Would be great if @wankunde has a chance to take a look ..
asfgit
pushed a commit
that referenced
this pull request
Nov 8, 2022
### What changes were proposed in this pull request? This PR is a followup of #37533 that fix the flaky test case. ### Why are the changes needed? The test case is flaky, and will failure due to some unexpected error. #37989 https://github.com/apache/spark/actions/runs/3145115911/jobs/5112006948 https://github.com/apache/spark/actions/runs/3146198025/jobs/5114387367 ### Does this PR introduce _any_ user-facing change? No, test-only. ### How was this patch tested? CI in this PR should verify that. Closes #38091 from wankunde/SPARK-40096-2. Authored-by: Kun Wan <wankun@apache.org> Signed-off-by: Mridul <mridul<at>gmail.com>
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
### What changes were proposed in this pull request? This PR is a followup of apache#37533 that fix the flaky test case. ### Why are the changes needed? The test case is flaky, and will failure due to some unexpected error. apache#37989 https://github.com/apache/spark/actions/runs/3145115911/jobs/5112006948 https://github.com/apache/spark/actions/runs/3146198025/jobs/5114387367 ### Does this PR introduce _any_ user-facing change? No, test-only. ### How was this patch tested? CI in this PR should verify that. Closes apache#38091 from wankunde/SPARK-40096-2. Authored-by: Kun Wan <wankun@apache.org> Signed-off-by: Mridul <mridul<at>gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a followup of #37533 that works around the test failure by explicitly checking the element and length in the test.
Why are the changes needed?
For an unknown reason the test added in is flaky even though both
ArrayBufferandListareSepand the test should pass up to my best knowledge. See https://github.com/apache/spark/actions/runs/3109851954/jobs/5040465291Does this PR introduce any user-facing change?
No, test-only.
How was this patch tested?
CI in this PR should verify that.