[MINOR][CONNECT][PYTHON] Miscellaneous cleanup in Spark Connect componenet#38121
Closed
HyukjinKwon wants to merge 1 commit intoapache:masterfrom
Closed
[MINOR][CONNECT][PYTHON] Miscellaneous cleanup in Spark Connect componenet#38121HyukjinKwon wants to merge 1 commit intoapache:masterfrom
HyukjinKwon wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
cc @dongjoon-hyun FYI |
Contributor
|
Big +1! LGTM |
dongjoon-hyun
approved these changes
Oct 6, 2022
Member
|
YarnClusterSuite failure is irrelevant to this PR. Merged to master. |
Contributor
|
Late LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes:
SparkConnectPlugin.scalaandSparkBuild.scalato be consistent with others.data_frametodataframeto be consistent with existing PySpark codes.This Pr is a sort of a followup of #37710
Why are the changes needed?
To follow existing codebase, and style.
Does this PR introduce any user-facing change?
No, the codes are not released yet. The only notable change would be renaming
data_frametodataframeto be consistent.How was this patch tested?
Ci in this PR should validate the changes.