Skip to content

[SPARK-40680][CONNECT][BUILD] Avoid hardcoded versions in SBT build#38133

Closed
HyukjinKwon wants to merge 1 commit intoapache:masterfrom
HyukjinKwon:SPARK-40680
Closed

[SPARK-40680][CONNECT][BUILD] Avoid hardcoded versions in SBT build#38133
HyukjinKwon wants to merge 1 commit intoapache:masterfrom
HyukjinKwon:SPARK-40680

Conversation

@HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

This PR proposes to read the corresponding versions from POM in SBT build instead of hardcoding the dependency versions.

In addition, this PR removes Scala system libraries in the dependency.

Why are the changes needed?

To avoid version duplication.

Does this PR introduce any user-facing change?

No, dev-only.

How was this patch tested?

CI in this PR should test it out.

@HyukjinKwon
Copy link
Member Author

cc @grundprinzip @amaliujia @LuciferYang FYI

@HyukjinKwon
Copy link
Member Author

@dongjoon-hyun
Copy link
Member

Could you re-trigger GitHub Action, @HyukjinKwon ?

@HyukjinKwon
Copy link
Member Author

(the build passed - there seems a problem with linking the build to this PR)

@amaliujia
Copy link
Contributor

thanks the change itself LGTM.

@amaliujia
Copy link
Contributor

Seeming the same issue on my PR: so probably an infra issue?

@amaliujia
Copy link
Contributor

Error: Unhandled error: HttpError: Resource not accessible by integration

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Oct 6, 2022

Not only PR linking, the master branch seems to be broken due to ghcr.io/apache/apache-spark-ci-image.

/usr/bin/docker --config /home/runner/work/_temp/.docker_ac20db86-d07f-459d-9681-cfa6ca3f8a2e pull ghcr.io/apache/apache-spark-ci-image:master-3197794220
  Error response from daemon: manifest unknown
  Error: Docker pull failed with exit code 1

@HyukjinKwon
Copy link
Member Author

Merged to master.

@dongjoon-hyun
Copy link
Member

+1, late LGTM.

@HyukjinKwon HyukjinKwon deleted the SPARK-40680 branch January 15, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants