[SPARK-40680][CONNECT][BUILD] Avoid hardcoded versions in SBT build#38133
Closed
HyukjinKwon wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-40680][CONNECT][BUILD] Avoid hardcoded versions in SBT build#38133HyukjinKwon wants to merge 1 commit intoapache:masterfrom
HyukjinKwon wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
cc @grundprinzip @amaliujia @LuciferYang FYI |
Member
Author
Member
|
Could you re-trigger GitHub Action, @HyukjinKwon ? |
Member
Author
|
(the build passed - there seems a problem with linking the build to this PR) |
Contributor
|
thanks the change itself LGTM. |
Contributor
|
Seeming the same issue on my PR: so probably an infra issue? |
Contributor
|
|
Member
|
Not only PR linking, the master branch seems to be broken due to |
Member
Author
|
Merged to master. |
Member
|
+1, late LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to read the corresponding versions from POM in SBT build instead of hardcoding the dependency versions.
In addition, this PR removes Scala system libraries in the dependency.
Why are the changes needed?
To avoid version duplication.
Does this PR introduce any user-facing change?
No, dev-only.
How was this patch tested?
CI in this PR should test it out.