[SPARK-37945][SQL][FOLLOWUP] Rename the error class INCORRECT_RUMP_UP_RATE#38391
Closed
MaxGekk wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-37945][SQL][FOLLOWUP] Rename the error class INCORRECT_RUMP_UP_RATE#38391MaxGekk wants to merge 2 commits intoapache:masterfrom
INCORRECT_RUMP_UP_RATE#38391MaxGekk wants to merge 2 commits intoapache:masterfrom
Conversation
Member
Author
Contributor
|
Sorry for the typo... and thanks a lot for fixing! Shall we change function name as well? |
Member
Author
Sure, I'll rename it too. Thanks. |
Member
Author
|
@cloud-fan @HyukjinKwon @srielau Are you ok with the trivial changes? If so, please, approve the PR. |
Member
Author
|
Merging the trivial changes to master. Thank you, @khalidmammadov for review. |
cloud-fan
approved these changes
Oct 26, 2022
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
…P_RATE` ### What changes were proposed in this pull request? In the PR, I propose to fix a typo by renaming the error class INCORRECT_RUMP_UP_RATE to INCORRECT_RAMP_UP_RATE, and rename the method `incorrectRumpUpRate()` to `incorrectRampUpRate()`. ### Why are the changes needed? To don't confuse user, and fix the typo. ### Does this PR introduce _any_ user-facing change? No. The error class hasn't released yet. ### How was this patch tested? By running the affected tests: ``` $ build/sbt "test:testOnly *RateStreamProviderSuite" $ build/sbt "core/testOnly *SparkThrowableSuite" ``` Closes apache#38391 from MaxGekk/rename-INCORRECT_RUMP_UP_RATE. Authored-by: Max Gekk <max.gekk@gmail.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to fix a typo by renaming the error class INCORRECT_RUMP_UP_RATE to INCORRECT_RAMP_UP_RATE, and rename the method
incorrectRumpUpRate()toincorrectRampUpRate().Why are the changes needed?
To don't confuse user, and fix the typo.
Does this PR introduce any user-facing change?
No. The error class hasn't released yet.
How was this patch tested?
By running the affected tests: