[SPARK-41228][SQL] Rename & Improve error message for COLUMN_NOT_IN_GROUP_BY_CLAUSE.
#38769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
reviewed
Nov 23, 2022
Contributor
Author
|
Fixed the Python test first since we have unresolved discussion #38769 (comment) |
Member
|
@itholic Please, rebase on the recent master. |
Member
|
@itholic Could you fix the test failure. It seems it is related to your changes: |
itholic
commented
Nov 30, 2022
|
|
||
| with QuietTest(self.sc): | ||
| with self.assertRaisesRegex(AnalysisException, "nor.*aggregate function"): | ||
| with self.assertRaisesRegex(AnalysisException, "[MISSING_AGGREGATION]"): |
Contributor
Author
There was a problem hiding this comment.
I think maybe we should test this with similar logic to checkError in Scala side.
Let me create the JIRA and update soon after getting some feedback from community.
MaxGekk
approved these changes
Dec 1, 2022
Member
|
+1, LGTM. Merging to master. |
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
…GROUP_BY_CLAUSE` ### What changes were proposed in this pull request? This PR proposes to rename `COLUMN_NOT_IN_GROUP_BY_CLAUSE` to `MISSING_AGGREGATION`. Also, improve its error message. ### Why are the changes needed? The current error class name and its error message doesn't illustrate the error cause and resolution correctly. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? ``` ./build/sbt “sql/testOnly org.apache.spark.sql.SQLQueryTestSuite*” ``` Closes apache#38769 from itholic/SPARK-41128. Authored-by: itholic <haejoon.lee@databricks.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to rename
COLUMN_NOT_IN_GROUP_BY_CLAUSEtoMISSING_AGGREGATION.Also, improve its error message.
Why are the changes needed?
The current error class name and its error message doesn't illustrate the error cause and resolution correctly.
Does this PR introduce any user-facing change?
No.
How was this patch tested?