[SPARK-41278][CONNECT] Clean up unused QualifiedAttribute in Expression.proto#38813
Closed
amaliujia wants to merge 2 commits into
Closed
[SPARK-41278][CONNECT] Clean up unused QualifiedAttribute in Expression.proto#38813amaliujia wants to merge 2 commits into
amaliujia wants to merge 2 commits into
Conversation
Author
grundprinzip
approved these changes
Nov 27, 2022
HyukjinKwon
approved these changes
Nov 28, 2022
Member
|
Merged to master. |
Contributor
|
late lgtm |
Contributor
|
late LGTM |
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 15, 2022
…on.proto ### What changes were proposed in this pull request? With apache@2b2ffcd there is no longer a need to have a schema field in `LocalRelation` proto, thus the old way to specify that schema which was `QualifiedAtttribute` is no longer used. This PR cleans `QualifiedAttribute` proto and all its unused code. ### Why are the changes needed? Codebase cleanup ### Does this PR introduce _any_ user-facing change? NO ### How was this patch tested? UT Closes apache#38813 from amaliujia/clean_up_qualified_attr_proto. Authored-by: Rui Wang <rui.wang@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
…on.proto ### What changes were proposed in this pull request? With apache@2b2ffcd there is no longer a need to have a schema field in `LocalRelation` proto, thus the old way to specify that schema which was `QualifiedAtttribute` is no longer used. This PR cleans `QualifiedAttribute` proto and all its unused code. ### Why are the changes needed? Codebase cleanup ### Does this PR introduce _any_ user-facing change? NO ### How was this patch tested? UT Closes apache#38813 from amaliujia/clean_up_qualified_attr_proto. Authored-by: Rui Wang <rui.wang@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
With 2b2ffcd there is no longer a need to have a schema field in
LocalRelationproto, thus the old way to specify that schema which wasQualifiedAtttributeis no longer used.This PR cleans
QualifiedAttributeproto and all its unused code.Why are the changes needed?
Codebase cleanup
Does this PR introduce any user-facing change?
NO
How was this patch tested?
UT