[SPARK-41256][CONNECT][FOLLOWUP] Fix compile error#38837
Closed
zhengruifeng wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-41256][CONNECT][FOLLOWUP] Fix compile error#38837zhengruifeng wants to merge 1 commit intoapache:masterfrom
zhengruifeng wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
HyukjinKwon
approved these changes
Nov 29, 2022
Member
|
Merged to master. |
Contributor
|
Thanks for fixing this quickly! LGTM! |
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 15, 2022
### What changes were proposed in this pull request? apache@4c35c5b made a breaking change in proto message, and cause apache@dcd9cae failed after merged ### Why are the changes needed? to fix compile error: ``` [error] /__w/spark/spark/connector/connect/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectPlannerSuite.scala:441:67: value setI32 is not a member of org.apache.spark.connect.proto.Expression.Literal.Builder [error] .setLiteral(proto.Expression.Literal.newBuilder.setI32(32)))) [error] ^ [error] /__w/spark/spark/connector/connect/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectPlannerSuite.scala:446:67: value setI32 is not a member of org.apache.spark.connect.proto.Expression.Literal.Builder [error] .setLiteral(proto.Expression.Literal.newBuilder.setI32(32))))) [error] ^ [error] /__w/spark/spark/connector/connect/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectPlannerSuite.scala:466:69: value setI32 is not a member of org.apache.spark.connect.proto.Expression.Literal.Builder [error] .setLiteral(proto.Expression.Literal.newBuilder.setI32(32))))) [error] ^ [error] three errors found ``` ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? local test Closes apache#38837 from zhengruifeng/connect_hot_fix. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
### What changes were proposed in this pull request? apache@4c35c5b made a breaking change in proto message, and cause apache@dcd9cae failed after merged ### Why are the changes needed? to fix compile error: ``` [error] /__w/spark/spark/connector/connect/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectPlannerSuite.scala:441:67: value setI32 is not a member of org.apache.spark.connect.proto.Expression.Literal.Builder [error] .setLiteral(proto.Expression.Literal.newBuilder.setI32(32)))) [error] ^ [error] /__w/spark/spark/connector/connect/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectPlannerSuite.scala:446:67: value setI32 is not a member of org.apache.spark.connect.proto.Expression.Literal.Builder [error] .setLiteral(proto.Expression.Literal.newBuilder.setI32(32))))) [error] ^ [error] /__w/spark/spark/connector/connect/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectPlannerSuite.scala:466:69: value setI32 is not a member of org.apache.spark.connect.proto.Expression.Literal.Builder [error] .setLiteral(proto.Expression.Literal.newBuilder.setI32(32))))) [error] ^ [error] three errors found ``` ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? local test Closes apache#38837 from zhengruifeng/connect_hot_fix. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
4c35c5b made a breaking change in proto message, and cause dcd9cae failed after merged
Why are the changes needed?
to fix compile error:
Does this PR introduce any user-facing change?
No
How was this patch tested?
local test