[SPARK-41326] [CONNECT] Fix deduplicate is missing input#38842
Closed
grundprinzip wants to merge 1 commit into
Closed
[SPARK-41326] [CONNECT] Fix deduplicate is missing input#38842grundprinzip wants to merge 1 commit into
grundprinzip wants to merge 1 commit into
Conversation
amaliujia
reviewed
Nov 29, 2022
| def plan(self, session: "SparkConnectClient") -> proto.Relation: | ||
| assert self._child is not None | ||
| plan = proto.Relation() | ||
| plan.deduplicate.input.CopyFrom(self._child.plan(session)) |
There was a problem hiding this comment.
this is a case that probably we have a test in test_connect_basic to avoid, maybe BTW add a test case there?
Contributor
Author
There was a problem hiding this comment.
The existing tests are exhaustive they just missed that the input was never copied.
There was a problem hiding this comment.
I won't block this PR by my comment.
Member
There was a problem hiding this comment.
Let me just merge this for now and go forward.
|
Can one of the admins verify this patch? |
HyukjinKwon
approved these changes
Nov 30, 2022
Member
|
Merged to master. |
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
### What changes were proposed in this pull request? In the transformation of the Spark Connect plan for `Deduplicate`, it was missing to copy the input relation into the plan. This caused an exception on the server and failing the query. This patch fixes that bug. ### Why are the changes needed? Bugfix ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? UT Closes apache#38842 from grundprinzip/SPARK-41326. Authored-by: Martin Grund <martin.grund@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the transformation of the Spark Connect plan for
Deduplicate, it was missing to copy the input relation into the plan. This caused an exception on the server and failing the query.This patch fixes that bug.
Why are the changes needed?
Bugfix
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT