[SPARK-41346][CONNECT][TESTS][FOLLOWUP] Fix test_connect_function to import PandasOnSparkTestCase properly
#38929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…import PandasOnSparkTestCase properly
dongjoon-hyun
changed the title
test_connect_function to import PandasOnSparkTestCase properly
Member
Author
HyukjinKwon
approved these changes
Dec 6, 2022
Member
Author
|
Thank you, @HyukjinKwon ! |
Member
Author
|
This is a single test file, |
Contributor
|
@dongjoon-hyun Thank you for doing this! |
Contributor
|
Thanks for keep driving this! |
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
…o import `PandasOnSparkTestCase` properly ### What changes were proposed in this pull request? This PR aims to fix `test_connect_function` to import `PandasOnSparkTestCase` properly. If we handle `import` properly, the test cases are ignored properly because `should_test_connect` assumes `have_pandas` https://github.com/apache/spark/blob/97976a5cc915597fd2606602d18c52c075a03bf6/python/pyspark/testing/connectutils.py#L49 ### Why are the changes needed? SPARK-41346 imported `PandasOnSparkTestCase` outside of `if have_pandas:`. https://github.com/apache/spark/blob/97976a5cc915597fd2606602d18c52c075a03bf6/python/pyspark/sql/tests/connect/test_connect_function.py#L25-L29 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? **BEFORE** ``` $ python/run-tests --testnames pyspark.sql.tests.connect.test_connect_function ... ModuleNotFoundError: No module named 'pandas' ``` **AFTER** ``` $ python/run-tests --testnames pyspark.sql.tests.connect.test_connect_function ... Skipped tests in pyspark.sql.tests.connect.test_connect_function with python3.9: test_aggregation_functions (pyspark.sql.tests.connect.test_connect_function.SparkConnectFunctionTests) ... skip (0.004s) test_math_functions (pyspark.sql.tests.connect.test_connect_function.SparkConnectFunctionTests) ... skip (0.004s) test_normal_functions (pyspark.sql.tests.connect.test_connect_function.SparkConnectFunctionTests) ... skip (0.002s) test_sort_with_nulls_order (pyspark.sql.tests.connect.test_connect_function.SparkConnectFunctionTests) ... skip (0.001s) test_sorting_functions_with_column (pyspark.sql.tests.connect.test_connect_function.SparkConnectFunctionTests) ... skip (0.001s) ``` Closes apache#38929 from dongjoon-hyun/SPARK-41346. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to fix
test_connect_functionto importPandasOnSparkTestCaseproperly. If we handleimportproperly, the test cases are ignored properly becauseshould_test_connectassumeshave_pandasspark/python/pyspark/testing/connectutils.py
Line 49 in 97976a5
Why are the changes needed?
SPARK-41346 imported
PandasOnSparkTestCaseoutside ofif have_pandas:.spark/python/pyspark/sql/tests/connect/test_connect_function.py
Lines 25 to 29 in 97976a5
Does this PR introduce any user-facing change?
No.
How was this patch tested?
BEFORE
AFTER