[SPARK-41404][SQL] Refactor ColumnVectorUtils#toBatch to make ColumnarBatchSuite#testRandomRows test more primitive dataType#38933
Closed
LuciferYang wants to merge 11 commits intoapache:masterfrom
Closed
Conversation
LuciferYang
changed the title
ColumnarBatchSuite#testRandomRows to test more primitive dataTypeColumnarBatchSuite#testRandomRows to test more primitive dataType
LuciferYang
changed the title
ColumnarBatchSuite#testRandomRows to test more primitive dataTypeColumnarBatchSuite#testRandomRows to test more primitive dataType
LuciferYang
commented
Dec 6, 2022
| dst.getChild(2).appendLong(c.microseconds); | ||
| } else if (t instanceof DateType) { | ||
| dst.appendInt(DateTimeUtils.fromJavaDate((Date)o)); | ||
| if (o instanceof Date) { |
Contributor
Author
There was a problem hiding this comment.
@cloud-fan As I mentioned at #38873 (comment)
ColumnVectorUtils#toBatch and related appendValue methods only used by test cases:
-
this pr add more primitive dataType support for
toBatchmethod and add more test inColumnarBatchSuite#testRandomRows, do you think this is valuable?I haven't created Jira. -
ColumnVectorUtils#toBatchonly used by test, should we move it fromColumnVectorUtilsto a test only helper class?
Contributor
There was a problem hiding this comment.
We should support all data types, but probably not all java types since it's test-only. We can require tests to only use Date or LocalDate.
For 2, I think it's fine to keep it here.
Contributor
Author
There was a problem hiding this comment.
OK, change to only test Date and Timestamp due they are default
LuciferYang
changed the title
ColumnarBatchSuite#testRandomRows to test more primitive dataTypeColumnarBatchSuite#testRandomRows to test more primitive dataType
LuciferYang
changed the title
ColumnarBatchSuite#testRandomRows to test more primitive dataTypeColumnarBatchSuite#testRandomRows test more dataType
LuciferYang
changed the title
ColumnarBatchSuite#testRandomRows test more dataTypeColumnVectorUtils#toBatch to make ColumnarBatchSuite#testRandomRows test more dataType
LuciferYang
changed the title
ColumnVectorUtils#toBatch to make ColumnarBatchSuite#testRandomRows test more dataTypeColumnVectorUtils#toBatch to make ColumnarBatchSuite#testRandomRows test more primitive dataType
cloud-fan
approved these changes
Dec 9, 2022
dongjoon-hyun
changed the title
ColumnVectorUtils#toBatch to make ColumnarBatchSuite#testRandomRows test more primitive dataTypeColumnVectorUtils#toBatch to make ColumnarBatchSuite#testRandomRows test more primitive dataType
dongjoon-hyun
approved these changes
Dec 10, 2022
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM.
Since this patch still touches sql/core/src/main, I removed [TESTS] from the PR title.
Contributor
Author
Thanks @dongjoon-hyun |
Member
|
Merged to master. |
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
…mnarBatchSuite#testRandomRows` test more primitive dataType ### What changes were proposed in this pull request? This pr refactor `ColumnVectorUtils#toBatch` to make `ColumnarBatchSuite#testRandomRows` to test more primitive dataType. ### Why are the changes needed? Support `ColumnarBatchSuite#testRandomRows` to test more primitive dataType ### Does this PR introduce _any_ user-facing change? No, just for test ### How was this patch tested? Pass GitHub Actions Closes apache#38933 from LuciferYang/toBatch-bugfix. Lead-authored-by: yangjie01 <yangjie01@baidu.com> Co-authored-by: YangJie <yangjie01@baidu.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr refactor
ColumnVectorUtils#toBatchto makeColumnarBatchSuite#testRandomRowsto test more primitive dataType.Why are the changes needed?
Support
ColumnarBatchSuite#testRandomRowsto test more primitive dataTypeDoes this PR introduce any user-facing change?
No, just for test
How was this patch tested?
Pass GitHub Actions