[MINOR][CONNECT][DOCS] Document parallelism=1 in Spark Connect testing#38992
Closed
HyukjinKwon wants to merge 1 commit intoapache:masterfrom
Closed
[MINOR][CONNECT][DOCS] Document parallelism=1 in Spark Connect testing#38992HyukjinKwon wants to merge 1 commit intoapache:masterfrom
HyukjinKwon wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
dongjoon-hyun
approved these changes
Dec 9, 2022
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Merged to master.
Contributor
|
+1 thanks |
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
### What changes were proposed in this pull request? This PR proposes to document the correct way of running Spark Connect tests with `--parallelism 1` option in `./python/run-tests` script. ### Why are the changes needed? Without this option, the tests cannot run due to the port conflicts. It fails with port already in use. ### Does this PR introduce _any_ user-facing change? No, dev-only. ### How was this patch tested? Manually ran the commands. Closes apache#38992 from HyukjinKwon/minor-docs-test. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to document the correct way of running Spark Connect tests with
--parallelism 1option in./python/run-testsscript.Why are the changes needed?
Without this option, the tests cannot run due to the port conflicts. It fails with port already in use.
Does this PR introduce any user-facing change?
No, dev-only.
How was this patch tested?
Manually ran the commands.