[SPARK-41462][SQL] Date and timestamp type can up cast to TimestampNTZ#38997
Closed
gengliangwang wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-41462][SQL] Date and timestamp type can up cast to TimestampNTZ#38997gengliangwang wants to merge 1 commit intoapache:masterfrom
gengliangwang wants to merge 1 commit intoapache:masterfrom
Conversation
cloud-fan
approved these changes
Dec 9, 2022
MaxGekk
approved these changes
Dec 9, 2022
Member
|
+1, LGTM. Merging to master. |
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
### What changes were proposed in this pull request? Handle TimestampNTZ in `Cast.canUpCast`: * Date and timestamp type can up cast to TimestampNTZ. * TimestampNTZ can up cast to Timestamp ### Why are the changes needed? Handle TimestampNTZ correctly in Cast.canUpCast. ### Does this PR introduce _any_ user-facing change? No, TimestampNTZ is not release yet. ### How was this patch tested? New UT Closes apache#38997 from gengliangwang/canUpCastNTZ. Authored-by: Gengliang Wang <gengliang@apache.org> Signed-off-by: Max Gekk <max.gekk@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Handle TimestampNTZ in
Cast.canUpCast:Why are the changes needed?
Handle TimestampNTZ correctly in Cast.canUpCast.
Does this PR introduce any user-facing change?
No, TimestampNTZ is not release yet.
How was this patch tested?
New UT