[SPARK-41526][CONNECT][PYTHON] Implement Column.isin#39074
Closed
zhengruifeng wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-41526][CONNECT][PYTHON] Implement Column.isin#39074zhengruifeng wants to merge 1 commit intoapache:masterfrom
Column.isin#39074zhengruifeng wants to merge 1 commit intoapache:masterfrom
Conversation
zhengruifeng
commented
Dec 15, 2022
| .Product(transformExpression(fun.getArgumentsList.asScala.head)) | ||
| .toAggregateExpression()) | ||
|
|
||
| case "in" => |
Contributor
Author
There was a problem hiding this comment.
if we don't intercept in here, it will fail with
raise self
grpc._channel._MultiThreadedRendezvous: <_MultiThreadedRendezvous of RPC that terminated with:
status = StatusCode.UNKNOWN
details = "[WRONG_NUM_ARGS.WITHOUT_SUGGESTION] Invalid number of arguments for the function `in`. Please, refer to 'https://spark.apache.org/docs/latest/sql-ref-functions.html' for a fix."
debug_error_string = "UNKNOWN:Error received from peer ipv6:%5B::1%5D:15002 {grpc_message:"[WRONG_NUM_ARGS.WITHOUT_SUGGESTION] Invalid number of arguments for the function `in`. Please, refer to \'https://spark.apache.org/docs/latest/sql-ref-functions.html\' for a fix.", grpc_status:2, created_time:"2022-12-15T17:17:23.380565+08:00"}"
>
This is the second case (the first one is when) that an expression has already been registered in FunctionRegistry, but do not have a constructor matching UnresolvedFunction.
I match them here instead of adding an extra constructor.
HyukjinKwon
approved these changes
Dec 15, 2022
Member
|
Merged to master. |
Contributor
Author
|
@HyukjinKwon THank you for reivews |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Implement
Column.isinWhy are the changes needed?
for API coverage
Does this PR introduce any user-facing change?
yes, new API
How was this patch tested?
added UT