[SPARK-41544][BUILD] Upgrade versions-maven-plugin used by test-dependencies.sh to 2.14.1#39089
Closed
LuciferYang wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-41544][BUILD] Upgrade versions-maven-plugin used by test-dependencies.sh to 2.14.1#39089LuciferYang wants to merge 1 commit intoapache:masterfrom
versions-maven-plugin used by test-dependencies.sh to 2.14.1#39089LuciferYang wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
I didn't choose to revert SPARK-41522 directly because I think it is safer to use a fixed version. For a new version, we can manually check before upgrading. Do you think it's ok? @HyukjinKwon @dongjoon-hyun |
Member
|
Yes, this is a better and correct way. We don't need to revert the old one, @LuciferYang . |
HyukjinKwon
approved these changes
Dec 16, 2022
Member
|
Merged to master. |
Contributor
Author
|
Thanks @dongjoon-hyun @HyukjinKwon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr introduced a new variable
VERSIONS_MAVEN_PLUGINfortest-dependencies.shto defineversions-maven-pluginand upgradeversions-maven-pluginfrom 2.13.0 to 2.14.1.Why are the changes needed?
Spark should use the verified version of
versions-maven-pluginto avoid unknown problems, such as those we encounter in SPARK-41522The release notes after 2.13.0 as follows:
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass Github Actions