[SPARK-41548][CONNECT][TESTS] Disable ANSI mode in pyspark.sql.tests.connect.test_connect_functions #39092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @xinrong-meng @zhengruifeng FYI |
dongjoon-hyun
approved these changes
Dec 16, 2022
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Merged to master.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Dec 31, 2022
…connect.test_connect_column ### What changes were proposed in this pull request? This PR proposes to disable ANSI mode in `pyspark.sql.tests.connect.test_connect_column` temporarily. This is a sort of a followup of #39241 and #39276. ### Why are the changes needed? To recover the broken ASNI build https://github.com/apache/spark/actions/runs/3791006074/jobs/6446116146. This is similar with #39092. ### Does this PR introduce _any_ user-facing change? No, test-only. ### How was this patch tested? Manually tested via: ```bash SPARK_ANSI_SQL_MODE=true ./python/run-tests --testnames 'pyspark.sql.tests.connect.test_connect_column' ``` Closes #39317 from HyukjinKwon/SPARK-41731-followup. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to disable ANSI mode in
pyspark.sql.tests.connect.test_connect_functionstemporarily.This PR is sort of a followup of #38946 and #39071
Why are the changes needed?
There are failures in
test_connect_functionswith ANSI mode on (https://github.com/apache/spark/actions/runs/3709431687/jobs/6288067223). I tried to fix but they are tricky to fix because Spark Connect does not respect the runtime configuration at the server side.It is also tricky to fix the test to pass in both ANSI mode on and off. Therefore, it disables temporarily to make other tests pass. Note that PySpark tests stop in the middle if one fails.
Does this PR introduce any user-facing change?
No, test-only.
How was this patch tested?
Manually verified that:
passes fine.