[SPARK-41801][CORE][PYTHON][PS] Remove *args: Any, **kwargs: Any for def transpose#39327
Closed
bjornjorgensen wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-41801][CORE][PYTHON][PS] Remove *args: Any, **kwargs: Any for def transpose#39327bjornjorgensen wants to merge 3 commits intoapache:masterfrom
*args: Any, **kwargs: Any for def transpose#39327bjornjorgensen wants to merge 3 commits intoapache:masterfrom
Conversation
bjornjorgensen
changed the title
*args: Any, **kwargs: Any for def transpose*args: Any, **kwargs: Any for def transpose
HyukjinKwon
reviewed
Jan 1, 2023
| agg = aggregate | ||
|
|
||
| def transpose(self, *args: Any, **kwargs: Any) -> "Series": | ||
| def transpose(self) -> "Series": |
Member
There was a problem hiding this comment.
Hm, I think we should better keep it for now for pandas compatibility.
Member
There was a problem hiding this comment.
Or would be nicer if we implement these parameters
|
Can one of the admins verify this patch? |
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Change
def transpose(self, *args: Any, **kwargs: Any) -> "Series":to
def transpose(self) -> "Series":Why are the changes needed?
def transpose(self, *args: Any, **kwargs: Any) -> "Series":This function only
return self.copy()Sonar
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.