Skip to content

[SPARK-41895][SS][UI] Add tests for streaming UI with RocksDB backend#39415

Closed
gengliangwang wants to merge 3 commits intoapache:masterfrom
gengliangwang:streamingTest
Closed

[SPARK-41895][SS][UI] Add tests for streaming UI with RocksDB backend#39415
gengliangwang wants to merge 3 commits intoapache:masterfrom
gengliangwang:streamingTest

Conversation

@gengliangwang
Copy link
Member

What changes were proposed in this pull request?

Add tests for streaming UI with RocksDB backend

Why are the changes needed?

Better test coverage when live UI with RocksDB backend is enabled.

Does this PR introduce any user-facing change?

No

How was this patch tested?

GA tests

@gengliangwang
Copy link
Member Author

cc @LuciferYang

@gengliangwang
Copy link
Member Author

I am rerunning tests since #39416 is merged.

@LuciferYang
Copy link
Contributor

13:45:13.014 ERROR org.apache.spark.sql.execution.streaming.StreamingQueryListenerBus: Listener StreamingQueryStatusListener threw an exception
java.lang.NullPointerException
	at org.apache.spark.status.protobuf.StoreTypes$StreamingQueryData$Builder.setName(StoreTypes.java:57107)
	at org.apache.spark.status.protobuf.sql.StreamingQueryDataSerializer.serialize(StreamingQueryDataSerializer.scala:33)
	at org.apache.spark.status.protobuf.KVStoreProtobufSerializer.serialize(KVStoreProtobufSerializer.scala:29)
	at org.apache.spark.util.kvstore.RocksDB.write(RocksDB.java:188)
	at org.apache.spark.status.ElementTrackingStore.write(ElementTrackingStore.scala:123)
	at org.apache.spark.status.ElementTrackingStore.write(ElementTrackingStore.scala:127)
	at org.apache.spark.sql.streaming.ui.StreamingQueryStatusListener.onQueryStarted(StreamingQueryStatusListener.scala:82)
	at org.apache.spark.sql.execution.streaming.StreamingQueryListenerBus.doPostEvent(StreamingQueryListenerBus.scala:131)
	at org.apache.spark.sql.execution.streaming.StreamingQueryListenerBus.doPostEvent(StreamingQueryListenerBus.scala:43)
	at org.apache.spark.util.ListenerBus.postToAll(ListenerBus.scala:117)
	at org.apache.spark.util.ListenerBus.postToAll$(ListenerBus.scala:101)
	at org.apache.spark.sql.execution.streaming.StreamingQueryListenerBus.postToAll(StreamingQueryListenerBus.scala:88)
	at org.apache.spark.sql.execution.streaming.StreamingQueryListenerBus.post(StreamingQueryListenerBus.scala:77)
	at org.apache.spark.sql.streaming.StreamingQueryManager.postListenerEvent(StreamingQueryManager.scala:231)
	at org.apache.spark.sql.execution.streaming.StreamExecution.postEvent(StreamExecution.scala:402)
	at org.apache.spark.sql.execution.streaming.StreamExecution.org$apache$spark$sql$execution$streaming$StreamExecution$$runStream(StreamExecution.scala:278)
	at org.apache.spark.sql.execution.streaming.StreamExecution$$anon$1.run(StreamExecution.scala:207)

data.name still needs to be protected to avoid NPE

Copy link
Contributor

@LuciferYang LuciferYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@gengliangwang
Copy link
Member Author

Merging to master

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @gengliangwang .
This might cause test flakiness. I saw several failures in these days. I filed a JIRA, SPARK-41969 for flaky tests. Could you take a look at this, please?

Screen Shot 2023-01-10 at 12 53 45 PM

Also, cc @xinrong-meng as Apache Spark 3.4.0 release manager.

@gengliangwang
Copy link
Member Author

@dongjoon-hyun yes I will try fixing it today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments