[SPARK-41824][CONNECT][PYTHON] Ingore the doctest for explain of connect#39436
Closed
beliefer wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-41824][CONNECT][PYTHON] Ingore the doctest for explain of connect#39436beliefer wants to merge 2 commits intoapache:masterfrom
beliefer wants to merge 2 commits intoapache:masterfrom
Conversation
HyukjinKwon
approved these changes
Jan 7, 2023
Member
HyukjinKwon
left a comment
HyukjinKwon
left a comment
There was a problem hiding this comment.
Let's remove the comment with the JIRA number too. LGTM otherwise.
Member
|
Merged to master. |
Contributor
|
LGTM, thank you @beliefer the df in PySpark will create a RDD at first, which can not be matched in Connect |
Contributor
Author
|
@HyukjinKwon @zhengruifeng Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, the output of explain API is different between pyspark, scala and connect.
There already created a dataframe with
df = spark.createDataFrame([(14, "Tom"), (23, "Alice"), (16, "Bob")], ["age", "name"])and then execute
df.explain()The output of pyspark show below.
But the scala and connect API output different content.
The similar issue occurs when executing
df.explain(mode="formatted")too.It's actually implementation details in PySpark. It would be difficult to make it matched. So this PR want ignore the two doc tests.
Why are the changes needed?
Currently, the output of explain API is different between pyspark, scala and connect.
This PR want ignore the two doc tests.
Does this PR introduce any user-facing change?
'No'.
New feature.
How was this patch tested?
Manual tests.