Skip to content

Conversation

@LuciferYang
Copy link
Contributor

@LuciferYang LuciferYang commented Jan 8, 2023

What changes were proposed in this pull request?

This pr aims upgrade scalatest related test dependencies to 3.2.15:

  • scalatest: upgrade scalatest to 3.2.15
  • scalatestplus
    • scalacheck: upgrade to scalacheck-1-17 3.2.15.0
    • mockito: upgrade to mockito-4-6 to 3.2.15.0
    • selenium: uprade to selenium-4-7 to 3.2.15.0 and selenium-java to 4.7.2, htmlunit-driver to 4.7.2

Why are the changes needed?

The release notes as follows:

Does this PR introduce any user-facing change?

No

How was this patch tested?

  • Pass GitHub Actions
  • Manual test:
    • ChromeUISeleniumSuite
    • RocksDBBackendChromeUIHistoryServerSuite
build/sbt -Dguava.version=31.1-jre -Dspark.test.webdriver.chrome.driver=/path/to/chromedriver -Dtest.default.exclude.tags="" -Phive -Phive-thriftserver "core/testOnly org.apache.spark.ui.ChromeUISeleniumSuite"

build/sbt -Dguava.version=31.1-jre -Dspark.test.webdriver.chrome.driver=/path/to/chromedriver -Dtest.default.exclude.tags="" -Phive -Phive-thriftserver "core/testOnly org.apache.spark.deploy.history.RocksDBBackendChromeUIHistoryServerSuite"
ChromeDriver was started successfully.
[info] - SPARK-31534: text for tooltip should be escaped (3 seconds, 421 milliseconds)
[info] - SPARK-31882: Link URL for Stage DAGs should not depend on paged table. (945 milliseconds)
[info] - SPARK-31886: Color barrier execution mode RDD correctly (310 milliseconds)
[info] - Search text for paged tables should not be saved (1 second, 761 milliseconds)
[info] Run completed in 10 seconds, 809 milliseconds.
[info] Total number of tests run: 4
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 4, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 123 s (02:03), completed 2023-1-8 21:33:56
ChromeDriver was started successfully.
[info] - ajax rendered relative links are prefixed with uiRoot (spark.ui.proxyBase) (2 seconds, 341 milliseconds)
[info] Run completed in 8 seconds, 792 milliseconds.
[info] Total number of tests run: 1
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 1, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 23 s, completed 2023-1-8 21:34:48

@LuciferYang LuciferYang marked this pull request as draft January 8, 2023 13:20
@github-actions github-actions bot added the BUILD label Jan 8, 2023
@LuciferYang LuciferYang marked this pull request as ready for review January 8, 2023 13:38
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Could you re-trigger the failed test to make it sure, please?

@LuciferYang
Copy link
Contributor Author

re-trigger the failed task

@dongjoon-hyun
Copy link
Member

Merged to master.

@LuciferYang
Copy link
Contributor Author

Thanks @dongjoon-hyun @HyukjinKwon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants