[SPARK-42167][INFRA] Improve GitHub Action lint job to stop on failures earlier#39716
Closed
dongjoon-hyun wants to merge 4 commits intoapache:masterfrom
dongjoon-hyun:SPARK-42167
Closed
[SPARK-42167][INFRA] Improve GitHub Action lint job to stop on failures earlier#39716dongjoon-hyun wants to merge 4 commits intoapache:masterfrom dongjoon-hyun:SPARK-42167
lint job to stop on failures earlier#39716dongjoon-hyun wants to merge 4 commits intoapache:masterfrom
dongjoon-hyun:SPARK-42167
Conversation
dongjoon-hyun
changed the title
lint job to stop on failures earlier
Member
Author
|
cc @HyukjinKwon |
Member
|
cc @Yikun too |
HyukjinKwon
reviewed
Jan 24, 2023
| python3.9 -m pip install 'sphinx<3.1.0' mkdocs pydata_sphinx_theme ipython nbsphinx numpydoc 'jinja2<3.0.0' 'markupsafe==2.0.1' 'pyzmq<24.0.0' | ||
| python3.9 -m pip install 'sphinx<3.1.0' mkdocs pydata_sphinx_theme nbsphinx numpydoc 'jinja2<3.0.0' 'markupsafe==2.0.1' 'pyzmq<24.0.0' | ||
| python3.9 -m pip install ipython_genutils # See SPARK-38517 | ||
| python3.9 -m pip install sphinx_plotly_directive 'numpy>=1.20.0' pyarrow pandas 'plotly>=4.8' 'grpcio==1.48.1' 'protobuf==3.19.5' 'mypy-protobuf==3.3.0' 'grpc-stubs==1.24.11' 'googleapis-common-protos-stubs==2.2.0' |
Member
There was a problem hiding this comment.
Thanks for separating this.
HyukjinKwon
approved these changes
Jan 24, 2023
Member
Author
|
Thank you, @HyukjinKwon . The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to improve
GitHub Actionlint job to stop on failure earlier.Why are the changes needed?
Currently, we designed to put all installation steps before testing. However, we don't need to install
SparkRdependency if the PR fails atLICENSEcheck.By pairing the installation and testing steps, we can skip as much as possible in case of failures.
Does this PR introduce any user-facing change?
No. This is a INFRA change.
How was this patch tested?
Manual review.