[SPARK-42187][CONNECT][TESTS] Avoid using RemoteSparkSession.builder.getOrCreate in tests#39743
Closed
HyukjinKwon wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-42187][CONNECT][TESTS] Avoid using RemoteSparkSession.builder.getOrCreate in tests#39743HyukjinKwon wants to merge 2 commits intoapache:masterfrom
HyukjinKwon wants to merge 2 commits intoapache:masterfrom
Conversation
HyukjinKwon
force-pushed
the
cleanup-test
branch
from
7776ae5 to
1e72578
Compare
itholic
approved these changes
Jan 26, 2023
Member
Author
|
All passed. Merged to master and branch-3.4. |
HyukjinKwon
added a commit
that referenced
this pull request
Jan 26, 2023
…getOrCreate in tests ### What changes were proposed in this pull request? This PR proposes to use `pyspark.sql.SparkSession.getOrCreate` instead of `pyspark.sql.connect.Sparksession.builder.getOrCreate`. ### Why are the changes needed? Because `pyspark.sql.connect.Sparksession.builder.getOrCreate` is supposed to be internal, and it does not have the unified handling of the Spark sessions for both PySpark session and Spark Connect sessions. ### Does this PR introduce _any_ user-facing change? No, test-only. ### How was this patch tested? Unittests fixed. Closes #39743 from HyukjinKwon/cleanup-test. Lead-authored-by: Hyukjin Kwon <gurwls223@apache.org> Co-authored-by: Hyukjin Kwon <gurwls223@gmail.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 4f60ebc) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to use
pyspark.sql.SparkSession.getOrCreateinstead ofpyspark.sql.connect.Sparksession.builder.getOrCreate.Why are the changes needed?
Because
pyspark.sql.connect.Sparksession.builder.getOrCreateis supposed to be internal, and it does not have the unified handling of the Spark sessions for both PySpark session and Spark Connect sessions.Does this PR introduce any user-facing change?
No, test-only.
How was this patch tested?
Unittests fixed.