Skip to content

Conversation

@sarutak
Copy link
Member

@sarutak sarutak commented Jan 9, 2015

.cmd files in bin is not set permission for execution except for spark-shell.cmd.
Let's unify that.

@SparkQA
Copy link

SparkQA commented Jan 9, 2015

Test build #25338 has finished for PR 3983 at commit 9d6eedc.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14
Copy link
Contributor

Hm, looks like everything else (not cmd) has 755 permissions though (except load-spark-env.sh)

@sarutak
Copy link
Member Author

sarutak commented Jan 9, 2015

Yes *.sh has 755 permissions but all cmd files except for spark-shell.cmd has 655. Is there any policy?

@srowen
Copy link
Member

srowen commented Jan 9, 2015

All other *.cmd files are 644 actually. I assume it's because .cmd files are Windows scripts and POSIX permission bits won't matter for them. If so, then the permissions are pretty irrelevant, but spark-shell.cmd could be 644 purely for consistency.

load-spark-env.sh could be 755, but I imagine it's not since it's not meant to be something executed by itself. It's sourced in other scripts. By that logic I'm not sure compute-classpath.sh should have execute bit set, but don't know.

@vanzin
Copy link
Contributor

vanzin commented Jan 10, 2015

BTW, I was testing some things on Windows the other day, and the 644 permissions did turn out to be an issue. Probably because I was rsyncing the files from a Linux host and rsync would then translate the permissions to not allow them to be executable on the Windows side...

@srowen
Copy link
Member

srowen commented Feb 6, 2015

Since this is trivial and makes the .cmd file match the others, I'll merge this.

@asfgit asfgit closed this in f6ba813 Feb 6, 2015
@JoshRosen
Copy link
Contributor

I've also merged this into branch-1.3 (1.3.0).

asfgit pushed a commit that referenced this pull request Feb 6, 2015
.cmd files in bin is not set permission for execution except for spark-shell.cmd.
Let's unify that.

Author: Kousuke Saruta <sarutak@oss.nttdata.co.jp>

Closes #3983 from sarutak/fix-mode-of-cmd and squashes the following commits:

9d6eedc [Kousuke Saruta] Removed permission for execution from spark-shell.cmd
@sarutak sarutak deleted the fix-mode-of-cmd branch April 11, 2015 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants