[SPARK-42273][CONNECT][TESTS] Skip Spark Connect tests if dependencies are not installed#39840
Closed
HyukjinKwon wants to merge 4 commits intoapache:masterfrom
Closed
[SPARK-42273][CONNECT][TESTS] Skip Spark Connect tests if dependencies are not installed#39840HyukjinKwon wants to merge 4 commits intoapache:masterfrom
HyukjinKwon wants to merge 4 commits intoapache:masterfrom
Conversation
Member
Author
zhengruifeng
approved these changes
Feb 1, 2023
dongjoon-hyun
approved these changes
Feb 1, 2023
Member
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @HyukjinKwon !
cf28282 to
2763f9c
Compare
2763f9c to
ff94d87
Compare
Member
Author
|
The last change was just to fix the type hint that dosen;t affect the test results. Merged to master and branch-3.4. |
HyukjinKwon
added a commit
that referenced
this pull request
Feb 2, 2023
…s are not installed
### What changes were proposed in this pull request?
This PR proposes to skip doctests if the dependencies for Spark Connect are not installed.
The skipping logic has to be added before the modules are loaded because it loads the module first when Python runs doctest. Otherwise, it fails as below:
```
Traceback (most recent call last):
File "/usr/local/Cellar/python3.9/3.9.10/Frameworks/Python.framework/Versions/3.9/lib/python3.9/runpy.py", line 197, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/usr/local/Cellar/python3.9/3.9.10/Frameworks/Python.framework/Versions/3.9/lib/python3.9/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "/.../spark/python/pyspark/sql/tests/connect/test_connect_basic.py", line 29, in <module>
from pyspark.sql.connect.client import Retrying
File "/.../spark/python/pyspark/sql/connect/__init__.py", line 21, in <module>
from pyspark.sql.connect.dataframe import DataFrame # noqa: F401
File "/.../spark/python/pyspark/sql/connect/dataframe.py", line 50, in <module>
import pyspark.sql.connect.plan as plan
File "/.../spark/python/pyspark/sql/connect/plan.py", line 26, in <module>
import pyspark.sql.connect.proto as proto
File "/.../spark/python/pyspark/sql/connect/proto/__init__.py", line 18, in <module>
from pyspark.sql.connect.proto.base_pb2_grpc import *
File "/.../spark/python/pyspark/sql/connect/proto/base_pb2_grpc.py", line 19, in <module>
import grpc
ModuleNotFoundError: No module named 'grpc'
```
### Why are the changes needed?
To make the tests pass without these optional dependencies.
### Does this PR introduce _any_ user-facing change?
No, dev-only.
### How was this patch tested?
```
./python/run-tests --module pyspark-connect -p 1
```
Closes #39840 from HyukjinKwon/SPARK-42273.
Lead-authored-by: Hyukjin Kwon <gurwls223@apache.org>
Co-authored-by: Hyukjin Kwon <gurwls223@gmail.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
(cherry picked from commit ca20e40)
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
…s are not installed
### What changes were proposed in this pull request?
This PR proposes to skip doctests if the dependencies for Spark Connect are not installed.
The skipping logic has to be added before the modules are loaded because it loads the module first when Python runs doctest. Otherwise, it fails as below:
```
Traceback (most recent call last):
File "/usr/local/Cellar/python3.9/3.9.10/Frameworks/Python.framework/Versions/3.9/lib/python3.9/runpy.py", line 197, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/usr/local/Cellar/python3.9/3.9.10/Frameworks/Python.framework/Versions/3.9/lib/python3.9/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "/.../spark/python/pyspark/sql/tests/connect/test_connect_basic.py", line 29, in <module>
from pyspark.sql.connect.client import Retrying
File "/.../spark/python/pyspark/sql/connect/__init__.py", line 21, in <module>
from pyspark.sql.connect.dataframe import DataFrame # noqa: F401
File "/.../spark/python/pyspark/sql/connect/dataframe.py", line 50, in <module>
import pyspark.sql.connect.plan as plan
File "/.../spark/python/pyspark/sql/connect/plan.py", line 26, in <module>
import pyspark.sql.connect.proto as proto
File "/.../spark/python/pyspark/sql/connect/proto/__init__.py", line 18, in <module>
from pyspark.sql.connect.proto.base_pb2_grpc import *
File "/.../spark/python/pyspark/sql/connect/proto/base_pb2_grpc.py", line 19, in <module>
import grpc
ModuleNotFoundError: No module named 'grpc'
```
### Why are the changes needed?
To make the tests pass without these optional dependencies.
### Does this PR introduce _any_ user-facing change?
No, dev-only.
### How was this patch tested?
```
./python/run-tests --module pyspark-connect -p 1
```
Closes apache#39840 from HyukjinKwon/SPARK-42273.
Lead-authored-by: Hyukjin Kwon <gurwls223@apache.org>
Co-authored-by: Hyukjin Kwon <gurwls223@gmail.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
(cherry picked from commit ca20e40)
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to skip doctests if the dependencies for Spark Connect are not installed.
The skipping logic has to be added before the modules are loaded because it loads the module first when Python runs doctest. Otherwise, it fails as below:
Why are the changes needed?
To make the tests pass without these optional dependencies.
Does this PR introduce any user-facing change?
No, dev-only.
How was this patch tested?