[SPARK-42115][SQL] Push down limit through Python UDFs#39842
Closed
kelvinjian-db wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-42115][SQL] Push down limit through Python UDFs#39842kelvinjian-db wants to merge 2 commits intoapache:masterfrom
kelvinjian-db wants to merge 2 commits intoapache:masterfrom
Conversation
cloud-fan
approved these changes
Feb 1, 2023
Contributor
|
This is actually a regression caused by #37941 |
HyukjinKwon
approved these changes
Feb 1, 2023
Contributor
|
The failed test is no longer valid: We can remove or ignore it. |
Contributor
|
thanks, merging to master/3.4! |
cloud-fan
pushed a commit
that referenced
this pull request
Feb 2, 2023
### What changes were proposed in this pull request? This PR adds cases in LimitPushDown to push limits through Python UDFs. In order to allow for this, we need to call LimitPushDown in SparkOptimizer after the "Extract Python UDFs" batch. We also add PushProjectionThroughLimit afterwards in order to plan CollectLimit. ### Why are the changes needed? Right now, LimitPushdown does not push limits through Python UDFs, which means that expensive Python UDFs can be run on potentially large amounts of input. This PR adds this capability, while ensuring that a GlobalLimit - LocalLimit pattern stays at the top in order to trigger the CollectLimit code path. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Added a UT. Closes #39842 from kelvinjian-db/SPARK-42115-limit-through-python-udfs. Authored-by: Kelvin Jiang <kelvin.jiang@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit 0fe361e) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
### What changes were proposed in this pull request? This PR adds cases in LimitPushDown to push limits through Python UDFs. In order to allow for this, we need to call LimitPushDown in SparkOptimizer after the "Extract Python UDFs" batch. We also add PushProjectionThroughLimit afterwards in order to plan CollectLimit. ### Why are the changes needed? Right now, LimitPushdown does not push limits through Python UDFs, which means that expensive Python UDFs can be run on potentially large amounts of input. This PR adds this capability, while ensuring that a GlobalLimit - LocalLimit pattern stays at the top in order to trigger the CollectLimit code path. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Added a UT. Closes apache#39842 from kelvinjian-db/SPARK-42115-limit-through-python-udfs. Authored-by: Kelvin Jiang <kelvin.jiang@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit 0fe361e) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds cases in LimitPushDown to push limits through Python UDFs. In order to allow for this, we need to call LimitPushDown in SparkOptimizer after the "Extract Python UDFs" batch. We also add PushProjectionThroughLimit afterwards in order to plan CollectLimit.
Why are the changes needed?
Right now, LimitPushdown does not push limits through Python UDFs, which means that expensive Python UDFs can be run on potentially large amounts of input. This PR adds this capability, while ensuring that a GlobalLimit - LocalLimit pattern stays at the top in order to trigger the CollectLimit code path.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added a UT.