[SPARK-42306][SQL] Integrate _LEGACY_ERROR_TEMP_1317 into UNRESOLVED_COLUMN.WITH_SUGGESTION#39877
Closed
itholic wants to merge 7 commits intoapache:masterfrom
Closed
[SPARK-42306][SQL] Integrate _LEGACY_ERROR_TEMP_1317 into UNRESOLVED_COLUMN.WITH_SUGGESTION#39877itholic wants to merge 7 commits intoapache:masterfrom
_LEGACY_ERROR_TEMP_1317 into UNRESOLVED_COLUMN.WITH_SUGGESTION#39877itholic wants to merge 7 commits intoapache:masterfrom
Conversation
…COLUMN.WITH_SUGGESTION
Contributor
Author
|
I think we can reuse |
srielau
approved these changes
Feb 3, 2023
MaxGekk
approved these changes
Feb 6, 2023
Member
|
Waiting for CI. |
Member
MaxGekk
pushed a commit
that referenced
this pull request
Feb 7, 2023
…ED_COLUMN.WITH_SUGGESTION`
### What changes were proposed in this pull request?
This PR proposes to integrate `_LEGACY_ERROR_TEMP_1317` into `UNRESOLVED_COLUMN.WITH_SUGGESTION`.
**_LEGACY_ERROR_TEMP_1317**
```json
"_LEGACY_ERROR_TEMP_1317" : {
"message" : [
"Cannot resolve column name \"<colName>\" among (<fieldsStr>)<extraMsg>"
]
},
```
**UNRESOLVED_COLUMN.WITH_SUGGESTION**
```json
"UNRESOLVED_COLUMN" : {
"message" : [
"A column or function parameter with name <objectName> cannot be resolved."
],
"subClass" : {
"WITHOUT_SUGGESTION" : {
"message" : [
""
]
},
"WITH_SUGGESTION" : {
"message" : [
"Did you mean one of the following? [<proposal>]."
]
}
},
"sqlState" : "42703"
},
```
### Why are the changes needed?
We should assign proper name to _LEGACY_ERROR_TEMP_*
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
`./build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite*"`
Closes #39877 from itholic/LEGACY_1317.
Authored-by: itholic <haejoon.lee@databricks.com>
Signed-off-by: Max Gekk <max.gekk@gmail.com>
(cherry picked from commit 6b6bb6f)
Signed-off-by: Max Gekk <max.gekk@gmail.com>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
…ED_COLUMN.WITH_SUGGESTION`
### What changes were proposed in this pull request?
This PR proposes to integrate `_LEGACY_ERROR_TEMP_1317` into `UNRESOLVED_COLUMN.WITH_SUGGESTION`.
**_LEGACY_ERROR_TEMP_1317**
```json
"_LEGACY_ERROR_TEMP_1317" : {
"message" : [
"Cannot resolve column name \"<colName>\" among (<fieldsStr>)<extraMsg>"
]
},
```
**UNRESOLVED_COLUMN.WITH_SUGGESTION**
```json
"UNRESOLVED_COLUMN" : {
"message" : [
"A column or function parameter with name <objectName> cannot be resolved."
],
"subClass" : {
"WITHOUT_SUGGESTION" : {
"message" : [
""
]
},
"WITH_SUGGESTION" : {
"message" : [
"Did you mean one of the following? [<proposal>]."
]
}
},
"sqlState" : "42703"
},
```
### Why are the changes needed?
We should assign proper name to _LEGACY_ERROR_TEMP_*
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
`./build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite*"`
Closes apache#39877 from itholic/LEGACY_1317.
Authored-by: itholic <haejoon.lee@databricks.com>
Signed-off-by: Max Gekk <max.gekk@gmail.com>
(cherry picked from commit 6b6bb6f)
Signed-off-by: Max Gekk <max.gekk@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to integrate
_LEGACY_ERROR_TEMP_1317intoUNRESOLVED_COLUMN.WITH_SUGGESTION._LEGACY_ERROR_TEMP_1317
UNRESOLVED_COLUMN.WITH_SUGGESTION
Why are the changes needed?
We should assign proper name to LEGACY_ERROR_TEMP*
Does this PR introduce any user-facing change?
No
How was this patch tested?
./build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite*"