[SPARK-42364][PS][TESTS] Split 'pyspark.pandas.tests.test_dataframe'#39915
Closed
zhengruifeng wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-42364][PS][TESTS] Split 'pyspark.pandas.tests.test_dataframe'#39915zhengruifeng wants to merge 1 commit intoapache:masterfrom
zhengruifeng wants to merge 1 commit intoapache:masterfrom
Conversation
HyukjinKwon
approved these changes
Feb 7, 2023
dongjoon-hyun
pushed a commit
that referenced
this pull request
Feb 7, 2023
### What changes were proposed in this pull request? Split 'pyspark.pandas.tests.test_dataframe' ### Why are the changes needed? 'pyspark.pandas.tests.test_dataframe' is too large: more than 7K lines, may take >15min sometimes ### Does this PR introduce _any_ user-facing change? No, test-only ### How was this patch tested? updated UT in my local env: 175 sec -> 95 sec + 102 sec Closes #39915 from zhengruifeng/ps_split_test_df. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 58b6535) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Contributor
Author
|
thank you @dongjoon-hyun @HyukjinKwon for the reviews! |
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
### What changes were proposed in this pull request? Split 'pyspark.pandas.tests.test_dataframe' ### Why are the changes needed? 'pyspark.pandas.tests.test_dataframe' is too large: more than 7K lines, may take >15min sometimes ### Does this PR introduce _any_ user-facing change? No, test-only ### How was this patch tested? updated UT in my local env: 175 sec -> 95 sec + 102 sec Closes apache#39915 from zhengruifeng/ps_split_test_df. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 58b6535) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Split 'pyspark.pandas.tests.test_dataframe'
Why are the changes needed?
'pyspark.pandas.tests.test_dataframe' is too large: more than 7K lines, may take >15min sometimes
Does this PR introduce any user-facing change?
No, test-only
How was this patch tested?
updated UT
in my local env: 175 sec -> 95 sec + 102 sec