Skip to content

[MINOR][DOCS] Add link to Hadoop docs#39941

Closed
martin-kokos wants to merge 1 commit intoapache:masterfrom
martin-kokos:patch-1
Closed

[MINOR][DOCS] Add link to Hadoop docs#39941
martin-kokos wants to merge 1 commit intoapache:masterfrom
martin-kokos:patch-1

Conversation

@martin-kokos
Copy link

What changes were proposed in this pull request?

Add link to Writable in Hadoop docs.

Why are the changes needed?

The python card of of the blue talks about Writables with no explanation what it is and the meaning of the whole paragraph is lost. While the Scala card links to Hadoop docs, the python card did not.

Does this PR introduce any user-facing change?

Help docs readability.

How was this patch tested?

Link is tested accessible.

@github-actions github-actions bot added the DOCS label Feb 8, 2023
@itholic
Copy link
Contributor

itholic commented Feb 8, 2023

Can we create corresponding JIRA ticket here, and add a JIRA number to the title??
e.g. [SPARK-12345][DOCS] Add link to Hadoop docs
or we can just add [MINOR] tag without creating ticket to JIRA, when the change is small enough.
e.g. [MINOR][DOCS] Add link to Hadoop docs

Btw, you can find more information for contributing Apache Spark here.

@itholic
Copy link
Contributor

itholic commented Feb 8, 2023

Also please check https://github.com/apache/spark/pull/39941/checks?check_run_id=11190702189 out to enable GitHub Actions in your forked repository

@itholic
Copy link
Contributor

itholic commented Feb 8, 2023

Anyway, seems fine to me when the test passed.

@martin-kokos martin-kokos changed the title [DOCS] Add link to Hadoop docs [MINOR][DOCS] Add link to Hadoop docs Feb 8, 2023
Copy link
Contributor

@itholic itholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're here, maybe can we fix other miscellaneous things together if you have some time?

e.g.
Writables -> Writable
IntWritables -> IntWritable
Texts -> Text
InputFormats -> InputFormat
...

They're not actually very big deal, though.

@martin-kokos
Copy link
Author

Fixed by c9c3880

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants