[SPARK-39904][SQL][FOLLOW-UP] Rename CSV option prefersDate as preferDate#40043
[SPARK-39904][SQL][FOLLOW-UP] Rename CSV option prefersDate as preferDate#40043gengliangwang wants to merge 1 commit intoapache:masterfrom
prefersDate as preferDate#40043Conversation
|
We discussed before and decided to keep prefersDate similar to a decimal config cc @HyukjinKwon |
|
Hmm, I take a quick check, do you mean the json option Shall we support |
|
im fine w/ that |
|
I am curious why did we not do it from the beginning? |
prefersDate as preferDateprefersDate as preferDate
I didn't join the discussion, but let's make the naming consistent before it is too late. There is only one exception |
|
Thanks, merging to master/3.4 |
…ferDate` ### What changes were proposed in this pull request? Rename the CSV data source option `prefersDate` as `preferDate`. ### Why are the changes needed? All the CSV data source options doesn't have a `s` on the verb in the naming. For example, `inferSchema`, `ignoreLeadingWhiteSpace` and `ignoreTrailingWhiteSpace`. The renaming makes the naming consistent. Also, the title of JIRA https://issues.apache.org/jira/browse/SPARK-39904 uses `preferDate` as well. ### Does this PR introduce _any_ user-facing change? No, the data source option is not released yet. ### How was this patch tested? Existing UT Closes #40043 from gengliangwang/renameCSVOption. Authored-by: Gengliang Wang <gengliang@apache.org> Signed-off-by: Gengliang Wang <gengliang@apache.org> (cherry picked from commit 6ead12e) Signed-off-by: Gengliang Wang <gengliang@apache.org>
…ferDate` ### What changes were proposed in this pull request? Rename the CSV data source option `prefersDate` as `preferDate`. ### Why are the changes needed? All the CSV data source options doesn't have a `s` on the verb in the naming. For example, `inferSchema`, `ignoreLeadingWhiteSpace` and `ignoreTrailingWhiteSpace`. The renaming makes the naming consistent. Also, the title of JIRA https://issues.apache.org/jira/browse/SPARK-39904 uses `preferDate` as well. ### Does this PR introduce _any_ user-facing change? No, the data source option is not released yet. ### How was this patch tested? Existing UT Closes apache#40043 from gengliangwang/renameCSVOption. Authored-by: Gengliang Wang <gengliang@apache.org> Signed-off-by: Gengliang Wang <gengliang@apache.org> (cherry picked from commit 6ead12e) Signed-off-by: Gengliang Wang <gengliang@apache.org>
What changes were proposed in this pull request?
Rename the CSV data source option
prefersDateaspreferDate.Why are the changes needed?
All the CSV data source options doesn't have a
son the verb in the naming. For example,inferSchema,ignoreLeadingWhiteSpaceandignoreTrailingWhiteSpace.The renaming makes the naming consistent.
Also, the title of JIRA https://issues.apache.org/jira/browse/SPARK-39904 uses
preferDateas well.Does this PR introduce any user-facing change?
No, the data source option is not released yet.
How was this patch tested?
Existing UT