[SPARK-42608][SQL] Use full inner field names in resolution errors#40202
Closed
aokolnychyi wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-42608][SQL] Use full inner field names in resolution errors#40202aokolnychyi wants to merge 1 commit intoapache:masterfrom
aokolnychyi wants to merge 1 commit intoapache:masterfrom
Conversation
dongjoon-hyun
approved these changes
Feb 28, 2023
huaxingao
approved these changes
Feb 28, 2023
cloud-fan
approved these changes
Feb 28, 2023
Member
|
Could you check the failures or re-trigger the CI for this PR, @aokolnychyi ? |
Contributor
Author
|
Test failures don't seem to be related. I see similar failures on other PRs. I think the root cause has been recently reverted in master. |
Member
|
You need to re-trigger CI, @aokolnychyi , because we cannot re-trigger for you. |
aokolnychyi
force-pushed
the
spark-42608
branch
from
16cc132 to
3269a74
Compare
dongjoon-hyun
pushed a commit
that referenced
this pull request
Feb 28, 2023
### What changes were proposed in this pull request? This PR makes `TableOutputResolver` use full names for inner fields in resolution errors. ### Why are the changes needed? These changes are needed to avoid confusion when there are multiple inner fields with the same name. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? This PR comes with tests. Closes #40202 from aokolnychyi/spark-42608. Authored-by: aokolnychyi <aokolnychyi@apple.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 74410ca) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
|
Merged to master/3.4 for Apache Spark 3.4.0. |
Contributor
Author
|
Thank you, @dongjoon-hyun @huaxingao @cloud-fan! |
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
### What changes were proposed in this pull request? This PR makes `TableOutputResolver` use full names for inner fields in resolution errors. ### Why are the changes needed? These changes are needed to avoid confusion when there are multiple inner fields with the same name. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? This PR comes with tests. Closes apache#40202 from aokolnychyi/spark-42608. Authored-by: aokolnychyi <aokolnychyi@apple.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 74410ca) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR makes
TableOutputResolveruse full names for inner fields in resolution errors.Why are the changes needed?
These changes are needed to avoid confusion when there are multiple inner fields with the same name.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
This PR comes with tests.