[SPARK-42670][BUILD] Upgrade maven-surefire-plugin to 3.0.0-M9 & eliminate build warnings#40278
Closed
panbingkun wants to merge 1 commit into
Closed
[SPARK-42670][BUILD] Upgrade maven-surefire-plugin to 3.0.0-M9 & eliminate build warnings#40278panbingkun wants to merge 1 commit into
panbingkun wants to merge 1 commit into
Conversation
…inate build warnings
LuciferYang
reviewed
Mar 5, 2023
| <SPARK_BEELINE_OPTS>-DmyKey=yourValue</SPARK_BEELINE_OPTS> | ||
| </environmentVariables> | ||
| <systemProperties> | ||
| <systemPropertyVariables> |
Contributor
There was a problem hiding this comment.
Are you using maven 3.9.0? There should be no this warning log in 3.8.7.
Contributor
There was a problem hiding this comment.
I think we don't need to make this change for the time being. Apache Spark has not promised to use maven 3.9.0 for build and test
Contributor
There was a problem hiding this comment.
And I think we should do this change after finish SPARK-42380 if there is no this warning log with maven 3.8.7
Member
There was a problem hiding this comment.
Does it hurt to make this change now? still works in Maven 3.8 and just prepares for 3.9?
Contributor
Author
There was a problem hiding this comment.
In fact, I think it can work well in maven 3.8.
BecausesystemProperties has been marked as Deprecated long ago.
Member
|
Merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to upgrade maven-surefire-plugin from 3.0.0-M8 to 3.0.0-M9 & eliminate build warnings.
Why are the changes needed?
apache/maven-surefire@surefire-3.0.0-M8...surefire-3.0.0-M9
system-properties
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual check & Pass GA.