Skip to content

Comments

[SPARK-42818][CONNECT][PYTHON] Implement DataFrameReader/Writer.jdbc#40450

Closed
ueshin wants to merge 2 commits intoapache:masterfrom
ueshin:issues/SPARK-42818/jdbc
Closed

[SPARK-42818][CONNECT][PYTHON] Implement DataFrameReader/Writer.jdbc#40450
ueshin wants to merge 2 commits intoapache:masterfrom
ueshin:issues/SPARK-42818/jdbc

Conversation

@ueshin
Copy link
Member

@ueshin ueshin commented Mar 15, 2023

What changes were proposed in this pull request?

Implements DataFrameReader/Writer.jdbc.

Why are the changes needed?

Missing API.

Does this PR introduce any user-facing change?

Yes, DataFrameReader/Writer.jdbc will be available.

How was this patch tested?

Added related tests.

@HyukjinKwon
Copy link
Member

Merged to master and branch-3.4.

HyukjinKwon pushed a commit that referenced this pull request Mar 16, 2023
### What changes were proposed in this pull request?

Implements `DataFrameReader/Writer.jdbc`.

### Why are the changes needed?

Missing API.

### Does this PR introduce _any_ user-facing change?

Yes, `DataFrameReader/Writer.jdbc` will be available.

### How was this patch tested?

Added related tests.

Closes #40450 from ueshin/issues/SPARK-42818/jdbc.

Authored-by: Takuya UESHIN <ueshin@databricks.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
(cherry picked from commit 8b2f28b)
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
@zhengruifeng
Copy link
Contributor

Late LGTM

zhengruifeng pushed a commit that referenced this pull request Mar 16, 2023
### What changes were proposed in this pull request?

Follow-up of #40450.

Adds `versionchanged` to the docstring.

### Why are the changes needed?

The `versionchanged` is missing in the API newly supported in Spark Connect.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Existing tests.

Closes #40451 from ueshin/issues/SPARK-42818/fup.

Authored-by: Takuya UESHIN <ueshin@databricks.com>
Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
zhengruifeng pushed a commit that referenced this pull request Mar 16, 2023
### What changes were proposed in this pull request?

Follow-up of #40450.

Adds `versionchanged` to the docstring.

### Why are the changes needed?

The `versionchanged` is missing in the API newly supported in Spark Connect.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Existing tests.

Closes #40451 from ueshin/issues/SPARK-42818/fup.

Authored-by: Takuya UESHIN <ueshin@databricks.com>
Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
(cherry picked from commit 23eaa38)
Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
snmvaughan pushed a commit to snmvaughan/spark that referenced this pull request Jun 20, 2023
### What changes were proposed in this pull request?

Implements `DataFrameReader/Writer.jdbc`.

### Why are the changes needed?

Missing API.

### Does this PR introduce _any_ user-facing change?

Yes, `DataFrameReader/Writer.jdbc` will be available.

### How was this patch tested?

Added related tests.

Closes apache#40450 from ueshin/issues/SPARK-42818/jdbc.

Authored-by: Takuya UESHIN <ueshin@databricks.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
(cherry picked from commit 8b2f28b)
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
snmvaughan pushed a commit to snmvaughan/spark that referenced this pull request Jun 20, 2023
### What changes were proposed in this pull request?

Follow-up of apache#40450.

Adds `versionchanged` to the docstring.

### Why are the changes needed?

The `versionchanged` is missing in the API newly supported in Spark Connect.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Existing tests.

Closes apache#40451 from ueshin/issues/SPARK-42818/fup.

Authored-by: Takuya UESHIN <ueshin@databricks.com>
Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
(cherry picked from commit 23eaa38)
Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants