[SPARK-42828][PYTHON][SQL] More explicit Python type annotations for GroupedData#40460
Closed
j03wang wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-42828][PYTHON][SQL] More explicit Python type annotations for GroupedData#40460j03wang wants to merge 1 commit intoapache:masterfrom
j03wang wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
@ueshin who last touched the type hints |
j03wang
changed the title
j03wang
changed the title
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
Member
|
@j03wang Sorry, I missed the ping. cc @xinrong-meng Could you take a look? |
j03wang
force-pushed
the
grouped-data-type
branch
from
12b6ae0 to
e52efc4
Compare
j03wang
force-pushed
the
grouped-data-type
branch
from
e52efc4 to
0ad5664
Compare
xinrong-meng
approved these changes
Jun 30, 2023
Member
|
Thanks for making the fix, LGTM! |
HyukjinKwon
approved these changes
Jul 3, 2023
Member
|
Merged to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Be more explicit in the
Callabletype annotation fordfapianddf_varargs_apito explicitly return aDataFrame.Why are the changes needed?
In PySpark 3.3.x, type hints now infer the return value of something like
df.groupBy(...).count()to beAny, whereas it should beDataFrame. This breaks type checking.Does this PR introduce any user-facing change?
No
How was this patch tested?
No runtime changes introduced, so just relied on CI tests.